Bug 161848

Summary:

REGRESSION (r205223): Web Inspector: Debugger popover title and code aren't horizontally aligned

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Bug	none
Patch	mattbaker: review+, mattbaker: commit-queue-
[Image] With patch applied	none
Patch	none
[Image] With patch applied	none

Nikita Vasilyev

Reported 2016-09-11 12:17:22 PDT

Created attachment 288530 [details] [Image] Bug The code is shifted a few pixels on the right. Must be a recent regression.

Attachments
[Image] Bug (47.29 KB, image/png) 2016-09-11 12:17 PDT, Nikita Vasilyev	no flags	Details
Patch (1.41 KB, patch) 2016-09-11 12:26 PDT, Nikita Vasilyev	mattbaker: review+ mattbaker: commit-queue-	Details Formatted Diff Diff
[Image] With patch applied (52.93 KB, image/png) 2016-09-11 12:31 PDT, Nikita Vasilyev	no flags	Details
Patch (2.11 KB, patch) 2016-09-12 15:08 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Image] With patch applied (52.44 KB, image/png) 2016-09-12 15:09 PDT, Nikita Vasilyev	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-09-11 12:17:58 PDT

<rdar://problem/28250703>

Nikita Vasilyev

Comment 2 2016-09-11 12:18:53 PDT

Regressed in bug 161417: Web Inspector: Remove largest common indentation spacing in debugger popover

Nikita Vasilyev

Comment 3 2016-09-11 12:26:59 PDT

Created attachment 288531 [details] Patch

Nikita Vasilyev

Comment 4 2016-09-11 12:31:27 PDT

Created attachment 288532 [details] [Image] With patch applied

Matt Baker

Comment 5 2016-09-11 16:14:38 PDT

Comment on attachment 288531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288531&action=review > Source/WebInspectorUI/ChangeLog:11 > + Overwrite left padding defined in CodeMirrorOverrides.css by `.CodeMirror pre` rule. Should be "Override".

Devin Rousso

Comment 6 2016-09-11 16:47:51 PDT

(In reply to comment #4) > Created attachment 288532 [details] > [Image] With patch applied Personally, I find it odd that the function name has a left padding while the source link doesn't have any right padding. Should we consider removing the padding for the function name altogether?

Matt Baker

Comment 7 2016-09-11 17:14:19 PDT

(In reply to comment #6) > (In reply to comment #4) > > Created attachment 288532 [details] > > [Image] With patch applied > > Personally, I find it odd that the function name has a left padding while > the source link doesn't have any right padding. Should we consider removing > the padding for the function name altogether? I didn't notice that! They should be the same.

Nikita Vasilyev

Comment 8 2016-09-12 15:08:45 PDT

Created attachment 288618 [details] Patch

Nikita Vasilyev

Comment 9 2016-09-12 15:09:27 PDT

Created attachment 288619 [details] [Image] With patch applied

WebKit Commit Bot

Comment 10 2016-09-12 15:37:25 PDT

Comment on attachment 288618 [details] Patch Clearing flags on attachment: 288618 Committed r205832: <http://trac.webkit.org/changeset/205832>

WebKit Commit Bot

Comment 11 2016-09-12 15:37:29 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.