Bug 161848

Summary:

REGRESSION (r205223): Web Inspector: Debugger popover title and code aren't horizontally aligned

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Bug	none
Patch	mattbaker: review+, mattbaker: commit-queue-
[Image] With patch applied	none
Patch	none
[Image] With patch applied	none

Description Nikita Vasilyev 2016-09-11 12:17:22 PDT

Created attachment 288530 [details]
[Image] Bug

The code is shifted a few pixels on the right. Must be a recent regression.

Comment 1 Radar WebKit Bug Importer 2016-09-11 12:17:58 PDT

<rdar://problem/28250703>

Comment 2 Nikita Vasilyev 2016-09-11 12:18:53 PDT

Regressed in bug 161417: Web Inspector: Remove largest common indentation spacing in debugger popover

Comment 3 Nikita Vasilyev 2016-09-11 12:26:59 PDT

Created attachment 288531 [details]
Patch

Comment 4 Nikita Vasilyev 2016-09-11 12:31:27 PDT

Created attachment 288532 [details]
[Image] With patch applied

Comment 5 Matt Baker 2016-09-11 16:14:38 PDT

Comment on attachment 288531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288531&action=review

> Source/WebInspectorUI/ChangeLog:11
> +        Overwrite left padding defined in CodeMirrorOverrides.css by `.CodeMirror pre` rule.

Should be "Override".

Comment 6 Devin Rousso 2016-09-11 16:47:51 PDT

(In reply to comment #4)
> Created attachment 288532 [details]
> [Image] With patch applied

Personally, I find it odd that the function name has a left padding while the source link doesn't have any right padding.  Should we consider removing the padding for the function name altogether?

Comment 7 Matt Baker 2016-09-11 17:14:19 PDT

(In reply to comment #6)
> (In reply to comment #4)
> > Created attachment 288532 [details]
> > [Image] With patch applied
> 
> Personally, I find it odd that the function name has a left padding while
> the source link doesn't have any right padding.  Should we consider removing
> the padding for the function name altogether?

I didn't notice that! They should be the same.

Comment 8 Nikita Vasilyev 2016-09-12 15:08:45 PDT

Created attachment 288618 [details]
Patch

Comment 9 Nikita Vasilyev 2016-09-12 15:09:27 PDT

Created attachment 288619 [details]
[Image] With patch applied

Comment 10 WebKit Commit Bot 2016-09-12 15:37:25 PDT

Comment on attachment 288618 [details]
Patch

Clearing flags on attachment: 288618

Committed r205832: <http://trac.webkit.org/changeset/205832>

Comment 11 WebKit Commit Bot 2016-09-12 15:37:29 PDT

All reviewed patches have been landed.  Closing bug.