Bug 161813 – [CSS Parser] Add the main parser implementation

• Component: CSS
• Status: RESOLVED FIXED

[Dave Hyatt]

[CSS Parser] Add the main parser implementation

[Dave Hyatt]

Created attachment 288437 [details]
Patch

Patch

[WebKit Commit Bot]

Attachment 288437 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:59:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:60:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:61:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:112:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:99:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:228:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:237:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:242:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:602:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:665:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:805:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/css/StyleRule.cpp:410:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSSupportsParser.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 13 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 288439 [details]
Patch

[WebKit Commit Bot]

Attachment 288439 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:99:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/css/StyleRule.cpp:410:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 288441 [details]
Patch

[Dean Jackson]

Comment on attachment 288441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288441&action=review

There are a bunch of // comments that are not ending with punctuation.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:246
> +    /*

Could you put a FIXME here?

[Build Bot]

Comment on attachment 288441 [details]
Patch

Attachment 288441 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2043497

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 288444 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Dave Hyatt]

Created attachment 288457 [details]
Patch to fix failures

[Dave Hyatt]

Landed in r205790.