Bug 161719

Summary: bitwise_cast: allow const destination type
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Web Template FrameworkAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

JF Bastien
Reported 2016-09-07 16:47:04 PDT
I was playing around with a bitwise_cast that could be added to the C++ standard (separate implementation and tests from WTF's), and this should be made to work: const To to = bitwise_cast<const To>(from); It's not super useful, but can happen when template-galore hits.
Attachments
patch (1.50 KB, patch)
2016-09-07 16:49 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
patch (1.50 KB, patch)
2016-09-07 17:03 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2016-09-07 16:49:15 PDT
Created attachment 288205 [details] patch
WebKit Commit Bot
Comment 2 2016-09-07 16:50:40 PDT
Attachment 288205 [details] did not pass style-queue: ERROR: Source/WTF/wtf/StdLibExtras.h:154: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
JF Bastien
Comment 3 2016-09-07 17:03:18 PDT
Created attachment 288208 [details] patch Fix style.
WebKit Commit Bot
Comment 4 2016-09-07 17:42:17 PDT
Comment on attachment 288208 [details] patch Clearing flags on attachment: 288208 Committed r205577: <http://trac.webkit.org/changeset/205577>
WebKit Commit Bot
Comment 5 2016-09-07 17:42:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.