Bug 161675

Summary:

Swipe gesture tests don't work on macOS Sierra

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bdakin, buildbot, commit-queue, dino, megan_gardner, simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

170381

Bug Blocks:

Attachments:

Description	Flags
First pass for EWS	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Tim Horton

Reported 2016-09-06 21:25:19 PDT

Swipe gesture tests don't work on macOS Sierra

Attachments
First pass for EWS (91.89 KB, patch) 2016-09-06 22:58 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (91.44 KB, patch) 2016-09-07 12:45 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (103.15 KB, patch) 2016-09-07 13:04 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (104.44 KB, patch) 2016-09-07 14:47 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (104.65 KB, patch) 2016-09-07 20:47 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (106.19 KB, patch) 2016-09-07 20:51 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (106.83 KB, patch) 2016-09-08 00:52 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (106.86 KB, patch) 2016-09-08 01:22 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (107.22 KB, patch) 2016-10-06 10:57 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (107.39 KB, patch) 2016-10-06 11:32 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (107.63 KB, patch) 2017-03-29 17:24 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2016-09-06 22:09:02 PDT

<rdar://problem/23379930>

Tim Horton

Comment 2 2016-09-06 22:58:11 PDT

Created attachment 288102 [details] First pass for EWS

Tim Horton

Comment 3 2016-09-06 23:02:44 PDT

Not for review yet, haven't written the changelog or cleaned things up all the way yet. And there is one test that I haven't repaired yet.

WebKit Commit Bot

Comment 4 2016-09-06 23:04:09 PDT

Attachment 288102 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:62: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/TestRunnerShared/spi/CoreGraphicsSPI.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:35: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:43: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:50: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:59: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:67: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:77: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:86: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:96: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:106: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:116: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:126: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:136: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:146: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:156: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:167: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:177: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:188: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:198: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:215: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:225: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:236: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:246: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:257: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:267: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:278: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:288: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:299: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:309: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:320: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:330: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:342: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:350: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:357: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:154: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:164: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:176: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:185: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:262: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:262: Missing spaces around / [whitespace/operators] [3] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:284: Missing spaces around / [whitespace/operators] [3] Total errors found: 45 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 5 2016-09-06 23:07:36 PDT

Comment on attachment 288102 [details] First pass for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=288102&action=review > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:83 > + return eventIsOfGestureType(event, first) || eventIsOfGestureTypes(event, rest...); smfr, this is for you. > Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:30 > +#define QUOTE(...) @(#__VA_ARGS__) this one too :)

Tim Horton

Comment 6 2016-09-07 12:45:54 PDT

Created attachment 288172 [details] Patch

WebKit Commit Bot

Comment 7 2016-09-07 12:50:39 PDT

Attachment 288172 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:265: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 34 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 8 2016-09-07 13:04:01 PDT

Created attachment 288174 [details] Patch

WebKit Commit Bot

Comment 9 2016-09-07 14:35:17 PDT

Attachment 288174 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:265: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 10 2016-09-07 14:47:18 PDT

Created attachment 288189 [details] Patch

WebKit Commit Bot

Comment 11 2016-09-07 14:48:18 PDT

Attachment 288189 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:265: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 12 2016-09-07 20:47:26 PDT

Created attachment 288235 [details] Patch

Tim Horton

Comment 13 2016-09-07 20:51:48 PDT

Created attachment 288236 [details] Patch

WebKit Commit Bot

Comment 14 2016-09-07 20:54:02 PDT

Attachment 288236 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:265: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 15 2016-09-08 00:52:05 PDT

Created attachment 288255 [details] Patch

WebKit Commit Bot

Comment 16 2016-09-08 00:57:50 PDT

Attachment 288255 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:43: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 17 2016-09-08 01:22:33 PDT

Created attachment 288256 [details] Patch

WebKit Commit Bot

Comment 18 2016-09-08 01:24:51 PDT

Attachment 288256 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:43: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 19 2016-10-06 10:57:57 PDT

Created attachment 290832 [details] Patch

WebKit Commit Bot

Comment 20 2016-10-06 11:00:35 PDT

Attachment 290832 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:43: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 21 2016-10-06 11:32:34 PDT

Created attachment 290837 [details] Patch

WebKit Commit Bot

Comment 22 2016-10-06 11:33:52 PDT

Attachment 290837 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:43: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 23 2016-10-07 11:52:41 PDT

Comment on attachment 290837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290837&action=review Sad we couldn’t use ARC for this test code. DIdn’t review this as carefully since it’s test code rather than code in WebKit proper, but this looks good to me. > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:36 > ++ (CGEventRef)createEventForDictionary:(NSDictionary *)dict inWindow:(NSWindow *)window relativeToTime:(CGEventTimestamp)referenceTimestamp; Could this return a RetainPtr<CGEventRef>? > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:41 > + RetainPtr<NSMutableArray *> _remainingEventDicts; dictionary is better, I think, than dict > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:198 > + CGEventRef plainEvent = CGEventCreate(NULL); I would have suggested adoptCF rather than the explicit CFRelease below. > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:206 > + dict[@"relativeTimeMS"] = @(std::max<double>(static_cast<double>(timestamp - referenceTimestamp) / NSEC_PER_MSEC, 0)); Could leave out the double from std::max<double> if you used "0.0" or "0." for the item on the right. Also nice to put that first so you don’t have to look so far to the right to get to the comma. > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:219 > + CGEventFlags flags = static_cast<CGEventFlags>(CGEventGetFlags(event) & ~NX_NONCOALSESCEDMASK); > + CGEventFlags plainFlags = static_cast<CGEventFlags>(CGEventGetFlags(plainEvent) & ~NX_NONCOALSESCEDMASK); surprised that the static_cast is required here; could use auto since it is, though > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:230 > + CGEventRef event = CGEventCreate(NULL); Ditto. > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:236 > + CGEventSetTimestamp(event, referenceTimestamp + static_cast<uint64_t>(([dict[@"relativeTimeMS"] doubleValue] * NSEC_PER_MSEC))); I don’t understand why uint64_t is the good type to cast to. Is that the same as CGEventTimestamp perhaps? > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:267 > + // This alloc is balanced with the release below in playbackTimerFired. Doesn’t a timer retain its target? Guess not. > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:283 > + RetainPtr<NSMutableArray *> removeList = adoptNS([[NSMutableArray alloc] init]); Could use auto here, adoptNS will get the type right without help. > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:306 > + [NSApp postEvent:[NSEvent otherEventWithType:applicationDefinedEventType location:NSZeroPoint modifierFlags:0 timestamp:0 windowNumber:0 context:0 subtype:0 data1:42 data2:0] atStart:NO]; Wow, 42. > Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:310 > + if (nextEvent.type == applicationDefinedEventType && nextEvent.data1 == 42) And there it is again, 42. Magic! > Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h:28 > +#import <AppKit/AppKit.h> Wow, that’s a lot to include just to get NSString! I probably would have done @class NSString, or maybe Foundation.h, or maybe nothing and depended on precompiled headers. > Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:37 > + "relativeTimeMS" : 0, These sure are wordy. > Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:80 > + RetainPtr<NSString> nsString = adoptNS((NSString *)JSStringCopyCFString(kCFAllocatorDefault, eventStream)); More correct to adoptCF and then cast to (NSString *) on use. More likely to get things right if we ever convert this code to ARC, for example.

Tim Horton

Comment 24 2017-03-29 17:24:05 PDT

Created attachment 305812 [details] Patch

Build Bot

Comment 25 2017-03-29 17:25:52 PDT

Attachment 305812 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:36: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:44: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:51: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:60: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:68: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:78: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:87: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:97: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:107: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:117: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:127: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:147: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:157: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:168: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:189: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:199: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:216: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:247: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:258: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:268: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:279: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:289: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:300: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:310: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:321: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:331: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:343: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:351: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm:358: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:43: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 34 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 26 2017-03-29 18:06:02 PDT

Comment on attachment 305812 [details] Patch Clearing flags on attachment: 305812 Committed r214586: <http://trac.webkit.org/changeset/214586>

WebKit Commit Bot

Comment 27 2017-03-29 18:06:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.