Summary: | [Win] Enable strict runtime stack buffer checks. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | Web Template Framework | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2016-09-06 08:43:06 PDT
Created attachment 288027 [details]
Patch
Comment on attachment 288027 [details]
Patch
r=me
Should we remove the compile option /GS then? Will this hurt performance? (In reply to comment #4) > Should we remove the compile option /GS then? Will this hurt performance? I believe the /GS option is needed to use the pragma. I don't think it will affect performance much, but it will add a little overhead to the functions where the compiler decides to emit these checks. Comment on attachment 288027 [details]
Patch
Thanks for reviewing :)
Comment on attachment 288027 [details] Patch Clearing flags on attachment: 288027 Committed r205497: <http://trac.webkit.org/changeset/205497> All reviewed patches have been landed. Closing bug. |