Bug 161629

Summary: [Win] Enable strict runtime stack buffer checks.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Web Template FrameworkAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2016-09-06 08:43:06 PDT
We can use #pragma strict_gs_check(on) to enable buffer checks in more cases than with the compile option /GS.
Comment 1 Per Arne Vollan 2016-09-06 08:47:04 PDT
Created attachment 288027 [details]
Patch
Comment 2 Per Arne Vollan 2016-09-06 08:49:23 PDT
<rdar://problem/9915569>
Comment 3 Brent Fulgham 2016-09-06 09:57:50 PDT
Comment on attachment 288027 [details]
Patch

r=me
Comment 4 Alex Christensen 2016-09-06 10:34:48 PDT
Should we remove the compile option /GS then?  Will this hurt performance?
Comment 5 Per Arne Vollan 2016-09-06 11:33:43 PDT
(In reply to comment #4)
> Should we remove the compile option /GS then?  Will this hurt performance?

I believe the /GS option is needed to use the pragma. I don't think it will affect performance much, but it will add a little overhead to the functions where the compiler decides to emit these checks.
Comment 6 Per Arne Vollan 2016-09-06 11:35:33 PDT
Comment on attachment 288027 [details]
Patch

Thanks for reviewing :)
Comment 7 WebKit Commit Bot 2016-09-06 11:57:01 PDT
Comment on attachment 288027 [details]
Patch

Clearing flags on attachment: 288027

Committed r205497: <http://trac.webkit.org/changeset/205497>
Comment 8 WebKit Commit Bot 2016-09-06 11:57:07 PDT
All reviewed patches have been landed.  Closing bug.