Bug 161629

Summary: [Win] Enable strict runtime stack buffer checks.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Web Template FrameworkAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2016-09-06 08:43:06 PDT
We can use #pragma strict_gs_check(on) to enable buffer checks in more cases than with the compile option /GS.
Attachments
Patch (1.01 KB, patch)
2016-09-06 08:47 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2016-09-06 08:47:04 PDT
Created attachment 288027 [details] Patch
Per Arne Vollan
Comment 2 2016-09-06 08:49:23 PDT
<rdar://problem/9915569>
Brent Fulgham
Comment 3 2016-09-06 09:57:50 PDT
Comment on attachment 288027 [details] Patch r=me
Alex Christensen
Comment 4 2016-09-06 10:34:48 PDT
Should we remove the compile option /GS then? Will this hurt performance?
Per Arne Vollan
Comment 5 2016-09-06 11:33:43 PDT
(In reply to comment #4) > Should we remove the compile option /GS then? Will this hurt performance? I believe the /GS option is needed to use the pragma. I don't think it will affect performance much, but it will add a little overhead to the functions where the compiler decides to emit these checks.
Per Arne Vollan
Comment 6 2016-09-06 11:35:33 PDT
Comment on attachment 288027 [details] Patch Thanks for reviewing :)
WebKit Commit Bot
Comment 7 2016-09-06 11:57:01 PDT
Comment on attachment 288027 [details] Patch Clearing flags on attachment: 288027 Committed r205497: <http://trac.webkit.org/changeset/205497>
WebKit Commit Bot
Comment 8 2016-09-06 11:57:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.