Bug 161570

Summary: Update the semantics of defined-ness of custom elements per spec changes
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Description Flags
Patch none

Description Ryosuke Niwa 2016-09-03 17:11:22 PDT
There has some changes to the way a custom element becomes :defined.
Namely, when a custom element constructor throws an exception,
the element is no longer considered as defined.

Furthermore, we should not try to upgrade such an element
when it's inserted back into a document.

Update our implementation of custom elements per these spec changes.
Comment 1 Ryosuke Niwa 2016-09-03 19:07:13 PDT
Created attachment 287885 [details]
Comment 2 Ryosuke Niwa 2016-09-03 21:49:42 PDT
Comment on attachment 287885 [details]

Thanks for the review.
Comment 3 WebKit Commit Bot 2016-09-03 22:11:24 PDT
Comment on attachment 287885 [details]

Clearing flags on attachment: 287885

Committed r205416: <http://trac.webkit.org/changeset/205416>
Comment 4 WebKit Commit Bot 2016-09-03 22:11:29 PDT
All reviewed patches have been landed.  Closing bug.