Bug 16157

Summary:

syntax highlighting does not handle RegExp literals containing quotes well

Product:

WebKit

Reporter:

Adam van den Hoven <adsmart>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED WONTFIX

Severity:

Normal

Keywords:

HasReduction

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Screenshot of the wrong syntax highlighting	none
Test case	none

Adam van den Hoven

Reported 2007-11-27 09:45:01 PST

It seems that the syntax highlighting used with Drosera does not understand Regular Expression literals correctly. The following resulted in odd syntax highlighting: replace(/"[^"\\\n\r]*"|true|false|null|-?\d+(?:\.\d*)?(:?[eE][+\-]?\d+)?/g, ']')

Attachments
Screenshot of the wrong syntax highlighting (55.73 KB, image/png) 2007-11-27 09:46 PST, Adam van den Hoven	no flags	Details
Test case (127 bytes, text/html) 2007-11-27 22:45 PST, David Kilzer (:ddkilzer)	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Adam van den Hoven

Comment 1 2007-11-27 09:46:01 PST

Created attachment 17556 [details] Screenshot of the wrong syntax highlighting

David Kilzer (:ddkilzer)

Comment 2 2007-11-27 10:28:56 PST

Thanks for the bug report! Which WebKit nightly were you using, e.g., rNNNNN?

Adam van den Hoven

Comment 3 2007-11-27 10:39:10 PST

(In reply to comment #2) > Thanks for the bug report! Which WebKit nightly were you using, e.g., rNNNNN? I have R28024 and I'm attaching it to Safari 3.0.4(5523.10) since I couldn't find any other way to get Drosera

David Kilzer (:ddkilzer)

Comment 4 2007-11-27 21:45:34 PST

(In reply to comment #3) > (In reply to comment #2) > > Thanks for the bug report! Which WebKit nightly were you using, e.g., rNNNNN? > > I have R28024 and I'm attaching it to Safari 3.0.4(5523.10) since I couldn't > find any other way to get Drosera What happens if you use Drosera r28024 and attach it to WebKit nightly r28024. Does it work then?

David Kilzer (:ddkilzer)

Comment 5 2007-11-27 22:43:57 PST

Confirmed with a local debug build of WebKit r28072 with Safari 3.0.4 (523.12) on Mac OS X 10.4.11 (8S165).

David Kilzer (:ddkilzer)

Comment 6 2007-11-27 22:45:01 PST

Created attachment 17569 [details] Test case 1. Attach Drosera. 2. Open this attachment in a new tab or window. 3. View source code in Drosera. Note highlighting issues.

Adam van den Hoven

Comment 7 2007-11-28 08:33:24 PST

(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Thanks for the bug report! Which WebKit nightly were you using, e.g., rNNNNN? > > > > I have R28024 and I'm attaching it to Safari 3.0.4(5523.10) since I couldn't > > find any other way to get Drosera > > What happens if you use Drosera r28024 and attach it to WebKit nightly r28024. > Does it work then? No. The syntax highlighting is still getting hung up on the regular expression literal.

Timothy Hatcher

Comment 8 2008-05-17 09:39:13 PDT

We plan to replace the syntax highlighter for the Web Inspector and that will be used for the new debugger. Closing since Drosera doesn't exist anymore.

Timothy Hatcher

Comment 9 2008-05-17 09:56:07 PDT

Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed.

Note You need to log in before you can comment on or make changes to this bug.