Summary: | Web Inspector: Update ESLint rules and run it over most of UserInterface | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | DoNotImportToRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-09-02 18:02:13 PDT
Created attachment 287847 [details]
[PATCH] Proposed Fix
Comment on attachment 287847 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287847&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Object.js:41 > + return listener; Why not return null or throw an exception in the exceptional cases? These are almost always programming errors we want to fail hard on. > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:992 > + let nextRecord = function(list) { return list.shift() || null; }; This could be an arrow, I suppose. Comment on attachment 287847 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287847&action=review >> Source/WebInspectorUI/UserInterface/Base/Object.js:41 >> + return listener; > > Why not return null or throw an exception in the exceptional cases? These are almost always programming errors we want to fail hard on. Okay |