Bug 161559

Summary: Media controls behave strangely when videos mute from within a playing handler
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2
none
Added a new test
none
Patch for landing none

Wenson Hsieh
Reported 2016-09-02 17:42:58 PDT
Media controls behave strangely when videos mute from within a playing handler
Attachments
Patch (4.53 KB, patch)
2016-09-02 17:58 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (37.81 KB, patch)
2016-09-03 18:12 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 (6.47 MB, application/zip)
2016-09-03 19:46 PDT, Build Bot 		no flags
Details
Added a new test (43.07 KB, patch)
2016-09-03 20:24 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (43.06 KB, patch)
2016-09-03 22:15 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2016-09-02 17:43:30 PDT
<rdar://problem/28018438>
Wenson Hsieh
Comment 2 2016-09-02 17:58:48 PDT
Created attachment 287841 [details] Patch
Wenson Hsieh
Comment 3 2016-09-03 18:12:38 PDT
Created attachment 287884 [details] Patch
Build Bot
Comment 4 2016-09-03 19:46:45 PDT
Comment on attachment 287884 [details] Patch Attachment 287884 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2003476 New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html
Build Bot
Comment 5 2016-09-03 19:46:48 PDT
Created attachment 287887 [details] Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Wenson Hsieh
Comment 6 2016-09-03 20:24:51 PDT
Created attachment 287890 [details] Added a new test
Darin Adler
Comment 7 2016-09-03 20:41:11 PDT
Comment on attachment 287890 [details] Added a new test View in context: https://bugs.webkit.org/attachment.cgi?id=287890&action=review > Source/WebCore/html/HTMLMediaElement.h:947 > + bool m_hasEverNotifiedAboutPlaying : 1; Is it really important to pack these bit fields tightly? It would be cleaner to initialize these in the header, but that would require spending 8 bits for each instead of 1 bit.
Wenson Hsieh
Comment 8 2016-09-03 22:00:56 PDT
Comment on attachment 287890 [details] Added a new test View in context: https://bugs.webkit.org/attachment.cgi?id=287890&action=review >> Source/WebCore/html/HTMLMediaElement.h:947 >> + bool m_hasEverNotifiedAboutPlaying : 1; > > Is it really important to pack these bit fields tightly? It would be cleaner to initialize these in the header, but that would require spending 8 bits for each instead of 1 bit. Interesting...this might be something to consider. For this file in particular, there are 30 bools defined this way. I don't think there are a whole lot of HTMLMediaElements though, so an additional 26 bytes per <video> doesn't seem bad at all.
Wenson Hsieh
Comment 9 2016-09-03 22:15:43 PDT
Created attachment 287898 [details] Patch for landing
WebKit Commit Bot
Comment 10 2016-09-03 22:47:06 PDT
Comment on attachment 287898 [details] Patch for landing Clearing flags on attachment: 287898 Committed r205417: <http://trac.webkit.org/changeset/205417>
WebKit Commit Bot
Comment 11 2016-09-03 22:47:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.