Summary: | Media controls behave strangely when videos mute from within a playing handler | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||
Component: | Media | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, jer.noble, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Wenson Hsieh
2016-09-02 17:42:58 PDT
Created attachment 287841 [details]
Patch
Created attachment 287884 [details]
Patch
Comment on attachment 287884 [details] Patch Attachment 287884 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2003476 New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html Created attachment 287887 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Created attachment 287890 [details]
Added a new test
Comment on attachment 287890 [details] Added a new test View in context: https://bugs.webkit.org/attachment.cgi?id=287890&action=review > Source/WebCore/html/HTMLMediaElement.h:947 > + bool m_hasEverNotifiedAboutPlaying : 1; Is it really important to pack these bit fields tightly? It would be cleaner to initialize these in the header, but that would require spending 8 bits for each instead of 1 bit. Comment on attachment 287890 [details] Added a new test View in context: https://bugs.webkit.org/attachment.cgi?id=287890&action=review >> Source/WebCore/html/HTMLMediaElement.h:947 >> + bool m_hasEverNotifiedAboutPlaying : 1; > > Is it really important to pack these bit fields tightly? It would be cleaner to initialize these in the header, but that would require spending 8 bits for each instead of 1 bit. Interesting...this might be something to consider. For this file in particular, there are 30 bools defined this way. I don't think there are a whole lot of HTMLMediaElements though, so an additional 26 bytes per <video> doesn't seem bad at all. Created attachment 287898 [details]
Patch for landing
Comment on attachment 287898 [details] Patch for landing Clearing flags on attachment: 287898 Committed r205417: <http://trac.webkit.org/changeset/205417> All reviewed patches have been landed. Closing bug. |