Bug 161559

Summary: Media controls behave strangely when videos mute from within a playing handler
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2
none
Added a new test
none
Patch for landing none

Description Wenson Hsieh 2016-09-02 17:42:58 PDT
Media controls behave strangely when videos mute from within a playing handler
Comment 1 Wenson Hsieh 2016-09-02 17:43:30 PDT
<rdar://problem/28018438>
Comment 2 Wenson Hsieh 2016-09-02 17:58:48 PDT
Created attachment 287841 [details]
Patch
Comment 3 Wenson Hsieh 2016-09-03 18:12:38 PDT
Created attachment 287884 [details]
Patch
Comment 4 Build Bot 2016-09-03 19:46:45 PDT
Comment on attachment 287884 [details]
Patch

Attachment 287884 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2003476

New failing tests:
fast/scrolling/ios/scrollTo-at-page-load.html
Comment 5 Build Bot 2016-09-03 19:46:48 PDT
Created attachment 287887 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 6 Wenson Hsieh 2016-09-03 20:24:51 PDT
Created attachment 287890 [details]
Added a new test
Comment 7 Darin Adler 2016-09-03 20:41:11 PDT
Comment on attachment 287890 [details]
Added a new test

View in context: https://bugs.webkit.org/attachment.cgi?id=287890&action=review

> Source/WebCore/html/HTMLMediaElement.h:947
> +    bool m_hasEverNotifiedAboutPlaying : 1;

Is it really important to pack these bit fields tightly? It would be cleaner to initialize these in the header, but that would require spending 8 bits for each instead of 1 bit.
Comment 8 Wenson Hsieh 2016-09-03 22:00:56 PDT
Comment on attachment 287890 [details]
Added a new test

View in context: https://bugs.webkit.org/attachment.cgi?id=287890&action=review

>> Source/WebCore/html/HTMLMediaElement.h:947
>> +    bool m_hasEverNotifiedAboutPlaying : 1;
> 
> Is it really important to pack these bit fields tightly? It would be cleaner to initialize these in the header, but that would require spending 8 bits for each instead of 1 bit.

Interesting...this might be something to consider. For this file in particular, there are 30 bools defined this way. I don't think there are a whole lot of HTMLMediaElements though, so an additional 26 bytes per <video> doesn't seem bad at all.
Comment 9 Wenson Hsieh 2016-09-03 22:15:43 PDT
Created attachment 287898 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2016-09-03 22:47:06 PDT
Comment on attachment 287898 [details]
Patch for landing

Clearing flags on attachment: 287898

Committed r205417: <http://trac.webkit.org/changeset/205417>
Comment 11 WebKit Commit Bot 2016-09-03 22:47:10 PDT
All reviewed patches have been landed.  Closing bug.