Bug 161470

Summary:

[JSC] Add initiator parameter to module pipeline

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

148897

Attachments:

Description	Flags
Patch	none

Description Yusuke Suzuki 2016-08-31 19:23:47 PDT

[JSC] Add initiator parameter to module pipeline

Comment 1 Yusuke Suzuki 2016-08-31 19:35:20 PDT

Created attachment 287585 [details]
Patch

Comment 2 Yusuke Suzuki 2016-08-31 19:49:54 PDT

Comment on attachment 287585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287585&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        For example, "nonce", "crossorigin" etc. attributes are shared in the fetching issued

typo, "in the fetching" => "in the fetching requests".

Comment 3 Saam Barati 2016-08-31 20:00:26 PDT

Comment on attachment 287585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287585&action=review

r=me

> Source/WebCore/bindings/js/JSMainThreadExecState.h:95
> +    static JSC::JSInternalPromise* loadModule(JSC::ExecState* exec, const String& moduleName, JSC::JSValue initiator)

Please update this file's copyright before landing.

Comment 4 Yusuke Suzuki 2016-08-31 20:47:32 PDT

Oops, accidentally cleared r+. Land that manually.

Comment 5 Yusuke Suzuki 2016-08-31 20:50:31 PDT

Committed r205278: <http://trac.webkit.org/changeset/205278>