Summary: | [GTK] Remove unused GObject DOM unstable API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, mcatanzaro, tpopela | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 161438, 161681 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2016-08-31 09:53:18 PDT
Yes, yes, yes, thank you! FYI: in GNOME unstable API is used by Epiphany, Evolution, and Yelp. epiphany -------- WebKitDOMDOMSelection webkit_dom_dom_window_get_selection webkit_dom_element_get_class_list yelp ---- webkit_dom_element_webkit_matches_selector evolution --------- webkit_dom_html_element_get_hidden webkit_dom_html_element_set_hidden WebKitDOMDOMSelection webkit_dom_dom_window_get_selection webkit_dom_element_insert_adjacent_html webkit_dom_document_caret_range_from_point webkit_dom_document_fragment_query_selector webkit_dom_html_element_set_spellcheck webkit_dom_range_expand So, for now making WebKitDOMDOMSelection stable and moving all unstable methods of WebKitDOMDOMWindow, WebKitDOMHTMLElement, WebKitDOMDocument, WebKitDOMDocumentFragment, WebKitDOMRange and WebKitDOMElement to stable would work for ephy, evo and yelp. I'll ask in the mailing list if someone else is using unstable API. Created attachment 288129 [details]
Patch
I hope I haven't missed anything. In any case we can bring back from unstable whatever we need on demand.
Committed r205543: <http://trac.webkit.org/changeset/205543> Carlos thank you for doing this! (In reply to comment #2) > evolution > --------- > > webkit_dom_html_element_get_hidden > webkit_dom_html_element_set_hidden > webkit_dom_html_element_set_spellcheck I think we don't need to expose these things as we can use the webkit_dom_element_set/get_attribute so you can remove them from the API if you want. |