Bug 161438

Summary: [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cdumez, darin
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161440    
Attachments:
Description Flags
Patch
none
Rebased again
mcatanzaro: review+
Patch for landing none

Carlos Garcia Campos
Reported 2016-08-31 08:46:17 PDT
For now copy all the generated bindings there as a first step, and remove all scripts related to the auto-generated bindings.
Attachments
Patch (4.07 MB, patch)
2016-08-31 09:28 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Rebased again (4.07 MB, patch)
2016-08-31 09:46 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Patch for landing (4.07 MB, patch)
2016-08-31 23:27 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-08-31 09:28:22 PDT
Created attachment 287514 [details] Patch I hope I haven't forgotten anything
Carlos Garcia Campos
Comment 2 2016-08-31 09:37:05 PDT
Patch is rebased to current trunk, I don't see anything wrong in the EWS output.
Carlos Garcia Campos
Comment 3 2016-08-31 09:46:00 PDT
Created attachment 287516 [details] Rebased again
Carlos Garcia Campos
Comment 4 2016-08-31 09:56:03 PDT
Maybe the problem is that it's a big patch and others land after it's started to be processed and before it finishes, even if it applies anyway.
Michael Catanzaro
Comment 5 2016-08-31 10:08:15 PDT
WebKitDOMAnimatable.[cpp,h] looks like it can be deleted. Unfortunately a lot of the files have "this file has been generated, DO NOT MODIFY!" and such at the top. You could try removing that and regenerating them all before removing the script again...?
Carlos Garcia Campos
Comment 6 2016-08-31 23:27:27 PDT
Created attachment 287602 [details] Patch for landing
Carlos Garcia Campos
Comment 7 2016-08-31 23:38:51 PDT
It seems impossible to test this patch with EWS :-( I'll land and check the bots.
Carlos Garcia Campos
Comment 8 2016-08-31 23:48:16 PDT
Committed r205280: <http://trac.webkit.org/changeset/205280>
Note You need to log in before you can comment on or make changes to this bug.