Summary: | [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bugs-noreply, cdumez, darin | ||||||||
Priority: | P2 | Keywords: | Gtk | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 161440 | ||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2016-08-31 08:46:17 PDT
Created attachment 287514 [details]
Patch
I hope I haven't forgotten anything
Patch is rebased to current trunk, I don't see anything wrong in the EWS output. Created attachment 287516 [details]
Rebased again
Maybe the problem is that it's a big patch and others land after it's started to be processed and before it finishes, even if it applies anyway. WebKitDOMAnimatable.[cpp,h] looks like it can be deleted. Unfortunately a lot of the files have "this file has been generated, DO NOT MODIFY!" and such at the top. You could try removing that and regenerating them all before removing the script again...? Created attachment 287602 [details]
Patch for landing
It seems impossible to test this patch with EWS :-( I'll land and check the bots. Committed r205280: <http://trac.webkit.org/changeset/205280> |