Bug 161412

Summary: WK2 Gamepad provider on iOS
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134076    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2016-08-30 16:14:43 PDT
WK2 Gamepad provider on iOS
Attachments
Patch (15.49 KB, patch)
2016-08-30 16:18 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (18.04 KB, patch)
2016-08-30 16:40 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (17.72 KB, patch)
2016-08-30 17:13 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (19.90 KB, patch)
2016-08-30 22:21 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (23.17 KB, patch)
2016-08-30 22:24 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-08-30 16:18:24 PDT
Created attachment 287448 [details] Patch
Tim Horton
Comment 2 2016-08-30 16:28:46 PDT
Comment on attachment 287448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287448&action=review > Source/WebKit2/Platform/spi/ios/UIKitSPI.h:829 > +- (UIResponder *) _responderForKeyEvents; no space after the ) > Source/WebKit2/UIProcess/Gamepad/ios/UIGamepadProviderIOS.mm:38 > + auto firstResponder = [[UIApplication sharedApplication] _responderForKeyEvents]; use firstResponder, I think
Brady Eidson
Comment 3 2016-08-30 16:40:30 PDT
Created attachment 287451 [details] Patch
Brady Eidson
Comment 4 2016-08-30 17:13:31 PDT
Created attachment 287461 [details] Patch
Brady Eidson
Comment 5 2016-08-30 22:21:03 PDT
Created attachment 287483 [details] Patch
Brady Eidson
Comment 6 2016-08-30 22:24:22 PDT
Created attachment 287485 [details] Patch
Alex Christensen
Comment 7 2016-08-31 01:06:23 PDT
Comment on attachment 287485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287485&action=review > Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:28 > +#if ENABLE(GAMEPAD) && (defined(__LP64__) || PLATFORM(IOS)) I think we should have a USE(GAME_CONTROLLER). This is quite unintuitive.
WebKit Commit Bot
Comment 8 2016-08-31 07:40:31 PDT
Comment on attachment 287485 [details] Patch Clearing flags on attachment: 287485 Committed r205247: <http://trac.webkit.org/changeset/205247>
WebKit Commit Bot
Comment 9 2016-08-31 07:40:42 PDT
All reviewed patches have been landed. Closing bug.
Brady Eidson
Comment 10 2016-08-31 08:27:40 PDT
(In reply to comment #7) > Comment on attachment 287485 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=287485&action=review > > > Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:28 > > +#if ENABLE(GAMEPAD) && (defined(__LP64__) || PLATFORM(IOS)) > > I think we should have a USE(GAME_CONTROLLER). This is quite unintuitive. Since its spread out all over at this point, will do in a follow up
Note You need to log in before you can comment on or make changes to this bug.