Bug 161412

Summary: WK2 Gamepad provider on iOS
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134076    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Brady Eidson 2016-08-30 16:14:43 PDT 
WK2 Gamepad provider on iOS
Comment 1 Brady Eidson 2016-08-30 16:18:24 PDT 
Created attachment 287448 [details]
Patch
Comment 2 Tim Horton 2016-08-30 16:28:46 PDT 
Comment on attachment 287448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287448&action=review

> Source/WebKit2/Platform/spi/ios/UIKitSPI.h:829
> +- (UIResponder *) _responderForKeyEvents;

no space after the )

> Source/WebKit2/UIProcess/Gamepad/ios/UIGamepadProviderIOS.mm:38
> +    auto firstResponder = [[UIApplication sharedApplication] _responderForKeyEvents];

use firstResponder, I think
Comment 3 Brady Eidson 2016-08-30 16:40:30 PDT 
Created attachment 287451 [details]
Patch
Comment 4 Brady Eidson 2016-08-30 17:13:31 PDT 
Created attachment 287461 [details]
Patch
Comment 5 Brady Eidson 2016-08-30 22:21:03 PDT 
Created attachment 287483 [details]
Patch
Comment 6 Brady Eidson 2016-08-30 22:24:22 PDT 
Created attachment 287485 [details]
Patch
Comment 7 Alex Christensen 2016-08-31 01:06:23 PDT 
Comment on attachment 287485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287485&action=review

> Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:28
> +#if ENABLE(GAMEPAD) && (defined(__LP64__) || PLATFORM(IOS))

I think we should have a USE(GAME_CONTROLLER).  This is quite unintuitive.
Comment 8 WebKit Commit Bot 2016-08-31 07:40:31 PDT 
Comment on attachment 287485 [details]
Patch

Clearing flags on attachment: 287485

Committed r205247: <http://trac.webkit.org/changeset/205247>
Comment 9 WebKit Commit Bot 2016-08-31 07:40:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Brady Eidson 2016-08-31 08:27:40 PDT 
(In reply to comment #7)
> Comment on attachment 287485 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=287485&action=review
> 
> > Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:28
> > +#if ENABLE(GAMEPAD) && (defined(__LP64__) || PLATFORM(IOS))
> 
> I think we should have a USE(GAME_CONTROLLER).  This is quite unintuitive.

Since its spread out all over at this point, will do in a follow up