Bug 161393

Summary: Object.getPrototypeOf() should return null cross-origin
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, ggaren, keith_miller, mark.lam, msaboff, rniwa, saam, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161396
https://bugs.webkit.org/show_bug.cgi?id=161455
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-08-30 11:16:23 PDT
Object.getPrototypeOf() should return null cross-origin: - https://html.spec.whatwg.org/#windowproxy-getprototypeof - https://html.spec.whatwg.org/#location-getprototypeof Firefox and Chrome return null. However, WebKit returns undefined.
Attachments
Patch (4.27 KB, patch)
2016-08-30 11:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-30 11:18:36 PDT
Created attachment 287413 [details] Patch
Chris Dumez
Comment 2 2016-08-31 11:20:22 PDT
Ping review?
Geoffrey Garen
Comment 3 2016-08-31 11:44:37 PDT
Comment on attachment 287413 [details] Patch r=me Not directly related to this patch, but it seems weird that Object.getPrototypeOf() needs to walk the stack. Why can't it just compare the callee's global object to the passed-in object's global object?
WebKit Commit Bot
Comment 4 2016-08-31 12:05:46 PDT
Comment on attachment 287413 [details] Patch Clearing flags on attachment: 287413 Committed r205258: <http://trac.webkit.org/changeset/205258>
WebKit Commit Bot
Comment 5 2016-08-31 12:06:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.