Bug 161378

Summary: Constructors of MathML renderers should only accept MathMLPresentationElement-derived classes
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Frédéric Wang (:fredw) 2016-08-30 06:18:24 PDT 
Constructors of RenderMathMLBlock, RenderMathMLTable and RenderMathMLToken must be modified to only accept MathMLPresentationElement-derived classes.
Comment 1 Frédéric Wang (:fredw) 2016-08-30 06:23:39 PDT 
Created attachment 287387 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2016-08-30 09:11:10 PDT 
(In reply to comment #0)
> Constructors of RenderMathMLBlock, RenderMathMLTable and RenderMathMLToken
> must be modified to only accept MathMLPresentationElement-derived classes.

RenderMathMLTable still derives from RenderTable which takes Element& as constructor and we don't have a cast from MathMLPresentationElement& to Element&, so let's handle that later.
Comment 3 Frédéric Wang (:fredw) 2016-08-30 23:25:10 PDT 
Created attachment 287492 [details]
Patch
Comment 4 WebKit Commit Bot 2016-09-03 14:34:41 PDT 
Comment on attachment 287492 [details]
Patch

Clearing flags on attachment: 287492

Committed r205408: <http://trac.webkit.org/changeset/205408>
Comment 5 WebKit Commit Bot 2016-09-03 14:34:46 PDT 
All reviewed patches have been landed.  Closing bug.