Bug 161378

Summary: Constructors of MathML renderers should only accept MathMLPresentationElement-derived classes
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Frédéric Wang (:fredw)
Reported 2016-08-30 06:18:24 PDT
Constructors of RenderMathMLBlock, RenderMathMLTable and RenderMathMLToken must be modified to only accept MathMLPresentationElement-derived classes.
Attachments
Patch (3.74 KB, patch)
2016-08-30 06:23 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (4.30 KB, patch)
2016-08-30 23:25 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-08-30 06:23:39 PDT
Created attachment 287387 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2016-08-30 09:11:10 PDT
(In reply to comment #0) > Constructors of RenderMathMLBlock, RenderMathMLTable and RenderMathMLToken > must be modified to only accept MathMLPresentationElement-derived classes. RenderMathMLTable still derives from RenderTable which takes Element& as constructor and we don't have a cast from MathMLPresentationElement& to Element&, so let's handle that later.
Frédéric Wang (:fredw)
Comment 3 2016-08-30 23:25:10 PDT
Created attachment 287492 [details] Patch
WebKit Commit Bot
Comment 4 2016-09-03 14:34:41 PDT
Comment on attachment 287492 [details] Patch Clearing flags on attachment: 287492 Committed r205408: <http://trac.webkit.org/changeset/205408>
WebKit Commit Bot
Comment 5 2016-09-03 14:34:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.