Bug 16136

Summary: Use shared PixelDumpSupport for Mac DRT
Product: WebKit Reporter: Sam Weinig <sam>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch aroben: review+

Sam Weinig
Reported 2007-11-25 18:25:56 PST
Now that the windows pixel dump code has landed, we should use the same code for both platform where possible.
Attachments
patch (70.54 KB, patch)
2007-11-26 10:47 PST, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2007-11-26 10:47:55 PST
Created attachment 17532 [details] patch
Adam Roben (:aroben)
Comment 2 2007-11-26 10:54:28 PST
Comment on attachment 17532 [details] patch You might mention in the ChangeLog that you're now using ImageDiffCG as well. +void drawWebViewIntoContext(CGContextRef); +void repaintWithVerticalSweep(CGContextRef); +void repaintWithHorizontalSweep(CGContextRef); +void drawSelectionRectIntoContext(CGContextRef, CGRect); How about: void paintWebView(CGContextRef); void repaintWebView(CGContextRef, bool horizontal); void drawSelectionRect(CGContextRef, const CGRect&); r=me
Sam Weinig
Comment 3 2007-11-26 13:17:06 PST
Fixes landed in r28042 and r28047.
Note You need to log in before you can comment on or make changes to this bug.