Bug 161320

Summary:

Move some structs into Connection.cpp

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Anders Carlsson 2016-08-29 11:40:28 PDT

Move some structs into Connection.cpp

Comment 1 Anders Carlsson 2016-08-29 11:41:07 PDT

Created attachment 287293 [details]
Patch

Comment 2 Darin Adler 2016-08-29 11:42:32 PDT

Comment on attachment 287293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287293&action=review

> Source/WebKit2/Platform/IPC/Connection.cpp:189
> +    uint64_t syncRequestID;

Could we initialize this to 0 here?

> Source/WebKit2/Platform/IPC/Connection.cpp:196
> +    bool didReceiveReply;

Could we initialize this to false here?

> Source/WebKit2/Platform/IPC/Connection.cpp:202
> +    PendingSyncReply()
> +        : syncRequestID(0)
> +        , didReceiveReply(false)
> +    {
> +    }

Would be nice if this was just "= default".

> Source/WebKit2/Platform/IPC/Connection.cpp:206
> +        , didReceiveReply(0)

This says 0 but should say false, but instead could be omitted.

Comment 3 Anders Carlsson 2016-08-29 11:47:33 PDT

(In reply to comment #2)
> Comment on attachment 287293 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=287293&action=review
> 
> > Source/WebKit2/Platform/IPC/Connection.cpp:189
> > +    uint64_t syncRequestID;
> 
> Could we initialize this to 0 here?
> 
> > Source/WebKit2/Platform/IPC/Connection.cpp:196
> > +    bool didReceiveReply;
> 
> Could we initialize this to false here?
> 
> > Source/WebKit2/Platform/IPC/Connection.cpp:202
> > +    PendingSyncReply()
> > +        : syncRequestID(0)
> > +        , didReceiveReply(false)
> > +    {
> > +    }
> 
> Would be nice if this was just "= default".

Fixed all of these, thanks!
> 
> > Source/WebKit2/Platform/IPC/Connection.cpp:206
> > +        , didReceiveReply(0)
> 
> This says 0 but should say false, but instead could be omitted.

Comment 4 Anders Carlsson 2016-08-29 11:47:53 PDT

Committed r205129: <http://trac.webkit.org/changeset/205129>