Bug 161275

Summary: Fix toStringName for Proxies and add support for normal instances
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2016-08-26 16:11:54 PDT
Fix toStringName for Proxies and add support for normal instances
Attachments
Patch (15.79 KB, patch)
2016-08-26 16:22 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (15.77 KB, patch)
2016-08-26 16:32 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.78 KB, patch)
2016-08-29 11:21 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-08-26 16:22:52 PDT
Created attachment 287170 [details] Patch
Keith Miller
Comment 2 2016-08-26 16:32:18 PDT
Created attachment 287172 [details] Patch
Saam Barati
Comment 3 2016-08-26 18:13:51 PDT
Comment on attachment 287172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287172&action=review > Source/JavaScriptCore/runtime/ObjectPrototype.cpp:301 > + String&& tag = thisObject->methodTable(exec->vm())->toStringName(thisObject, exec); Why the && here? Why not just do: String tag = ...; ... String newString = WTF::tryMakeString("[object ", WTFMove(tag), "]"); ...
Keith Miller
Comment 4 2016-08-29 11:17:29 PDT
Comment on attachment 287172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287172&action=review >> Source/JavaScriptCore/runtime/ObjectPrototype.cpp:301 >> + String&& tag = thisObject->methodTable(exec->vm())->toStringName(thisObject, exec); > > Why the && here? > Why not just do: > String tag = ...; > ... > String newString = WTF::tryMakeString("[object ", WTFMove(tag), "]"); > ... Yeah, I dunno why I did it this way. I'll switch.
Keith Miller
Comment 5 2016-08-29 11:21:45 PDT
Created attachment 287285 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-08-29 11:52:34 PDT
Comment on attachment 287285 [details] Patch for landing Clearing flags on attachment: 287285 Committed r205131: <http://trac.webkit.org/changeset/205131>
WebKit Commit Bot
Comment 7 2016-08-29 11:52:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.