Bug 16126

Summary: Compiler warning in Javascript/PCRE
Product: WebKit Reporter: Laszlo Gombos <laszlo_gombos>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: laszlo_gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fix attached. mjs: review+

Laszlo Gombos
Reported 2007-11-24 19:13:22 PST
JavaScriptCore/pcre/pcre_ucp_searchfuncs.cpp: In function ‘int _pcre_ucp_othercase(int)’: JavaScriptCore/pcre/pcre_ucp_searchfuncs.cpp:78: warning: comparison between signed and unsigned integer expressions JavaScriptCore/pcre/pcre_ucp_searchfuncs.cpp:79: warning: comparison between signed and unsigned integer expressions JavaScriptCore/pcre/pcre_ucp_searchfuncs.cpp:84: warning: comparison between signed and unsigned integer expressions
Attachments
Fix attached. (1.46 KB, patch)
2007-11-24 19:15 PST, Laszlo Gombos 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2007-11-24 19:15:03 PST
Created attachment 17495 [details] Fix attached. Similar change is made already in the latest PCRE release (7.4)
Maciej Stachowiak
Comment 2 2007-11-24 19:25:19 PST
Comment on attachment 17495 [details] Fix attached. Eric may have already fixed this in his assorted pcre fixes, but in any case this looks fine to me.
Mark Rowe (bdash)
Comment 3 2007-11-25 18:13:01 PST
Landed in r28027.
Note You need to log in before you can comment on or make changes to this bug.