Bug 161255

Summary: The :enabled/:disabled selectors should only match elements that can be disabled.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
cdumez: review+, cdumez: commit-queue-
Moon lander none

Description Andreas Kling 2016-08-26 11:19:39 PDT
We're failing imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html because HTMLOutputElement can get incorrectly matched by :enabled and :disabled selectors.
Comment 1 Andreas Kling 2016-08-26 11:21:57 PDT
Created attachment 287126 [details]
Patch
Comment 2 Andreas Kling 2016-08-26 13:22:09 PDT
Created attachment 287136 [details]
Patch
Comment 3 WebKit Commit Bot 2016-08-26 13:25:27 PDT
Attachment 287136 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.cpp:52:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2016-08-26 13:25:29 PDT
Created attachment 287138 [details]
Patch
Comment 5 WebKit Commit Bot 2016-08-26 13:26:50 PDT
Attachment 287138 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.cpp:52:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Chris Dumez 2016-08-26 13:53:42 PDT
Comment on attachment 287138 [details]
Patch

r=me
Comment 7 Chris Dumez 2016-08-26 14:12:29 PDT
Comment on attachment 287138 [details]
Patch

style
Comment 8 Andreas Kling 2016-08-26 14:17:21 PDT
Created attachment 287147 [details]
Moon  lander
Comment 9 WebKit Commit Bot 2016-08-26 14:47:54 PDT
Comment on attachment 287147 [details]
Moon  lander

Clearing flags on attachment: 287147

Committed r205050: <http://trac.webkit.org/changeset/205050>
Comment 10 WebKit Commit Bot 2016-08-26 14:47:58 PDT
All reviewed patches have been landed.  Closing bug.