| Summary: | REGRESSION(r204028): Fix unused-but-set-variable warning in generated JSNavigator.cpp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, cgarcia, commit-queue, darin, esprehn+autocc, ggaren, kondapallykalyan, ossy, rniwa, sam, youennf | ||||
| Priority: | P2 | ||||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 160394 | ||||||
| Attachments: |
|
||||||
It seems it is a regression caused by https://trac.webkit.org/changeset/204028 Created attachment 287118 [details]
Patch
Comment on attachment 287118 [details] Patch Clearing flags on attachment: 287118 Committed r205048: <http://trac.webkit.org/changeset/205048> All reviewed patches have been landed. Closing bug. Follow-up fix in <http://trac.webkit.org/changeset/205061>. |
DerivedSources/WebCore/JSNavigator.cpp: In function 'JSC::EncodedJSValue WebCore::jsNavigatorPrototypeFunctionVibrate(JSC::ExecState*)': DerivedSources/WebCore/JSNavigator.cpp:977:17: error: variable 'distinguishingArg' set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors ------------------------------------------------------------------------------------------------------------------- EncodedJSValue JSC_HOST_CALL jsNavigatorPrototypeFunctionVibrate(ExecState* state) { size_t argsCount = std::min<size_t>(1, state->argumentCount()); if (argsCount == 1) { JSValue distinguishingArg = state->uncheckedArgument(0); #if ENABLE(VIBRATION) if (hasIteratorMethod(*state, distinguishingArg)) return jsNavigatorPrototypeFunctionVibrate1(state); #endif #if ENABLE(VIBRATION) if (distinguishingArg.isNumber()) return jsNavigatorPrototypeFunctionVibrate2(state); #endif #if ENABLE(VIBRATION) return jsNavigatorPrototypeFunctionVibrate2(state); #endif } return argsCount < 1 ? throwVMError(state, createNotEnoughArgumentsError(state)) : throwVMTypeError(state); } -------------------------------------------------------------------------------------------------------------------