Bug 161245

Summary:

Remove StylePendingImage

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
patch	none

Antti Koivisto

Reported 2016-08-26 08:12:42 PDT

Instances of this confusing type are used as placeholders during style resolution. We should get rid of it and make "pending" a state of StyleImage.

Attachments
patch (61.63 KB, patch) 2016-08-29 08:01 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (61.65 KB, patch) 2016-08-29 08:14 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (837.99 KB, application/zip) 2016-08-29 09:07 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (930.17 KB, application/zip) 2016-08-29 09:10 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (1.46 MB, application/zip) 2016-08-29 09:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2 (699.54 KB, application/zip) 2016-08-29 09:22 PDT, Build Bot	no flags	Details
patch (61.55 KB, patch) 2016-08-29 11:23 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-yosemite (1.70 MB, application/zip) 2016-08-29 12:14 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (1.00 MB, application/zip) 2016-08-29 12:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1017.29 KB, application/zip) 2016-08-29 12:20 PDT, Build Bot	no flags	Details
patch (61.58 KB, patch) 2016-08-29 12:28 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-08-29 08:01:16 PDT

Created attachment 287265 [details] patch

Antti Koivisto

Comment 2 2016-08-29 08:14:47 PDT

Created attachment 287266 [details] patch

Build Bot

Comment 3 2016-08-29 09:07:21 PDT

Comment on attachment 287266 [details] patch Attachment 287266 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1966122 New failing tests: http/tests/css/border-image-loading.html

Build Bot

Comment 4 2016-08-29 09:07:24 PDT

Created attachment 287269 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-08-29 09:10:56 PDT

Comment on attachment 287266 [details] patch Attachment 287266 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1966129 New failing tests: http/tests/css/border-image-loading.html

Build Bot

Comment 6 2016-08-29 09:10:59 PDT

Created attachment 287270 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-08-29 09:15:03 PDT

Comment on attachment 287266 [details] patch Attachment 287266 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1966127 New failing tests: http/tests/css/border-image-loading.html

Build Bot

Comment 8 2016-08-29 09:15:06 PDT

Created attachment 287271 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-08-29 09:22:42 PDT

Comment on attachment 287266 [details] patch Attachment 287266 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1966137 New failing tests: http/tests/css/border-image-loading.html

Build Bot

Comment 10 2016-08-29 09:22:48 PDT

Created attachment 287272 [details] Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5

Antti Koivisto

Comment 11 2016-08-29 11:23:37 PDT

Created attachment 287286 [details] patch

Build Bot

Comment 12 2016-08-29 12:14:28 PDT

Comment on attachment 287286 [details] patch Attachment 287286 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1966933 New failing tests: svg/webarchive/svg-cursor-subresources.svg fast/events/mouse-cursor.html svg/W3C-SVG-1.1/interact-cursor-01-f.svg

Build Bot

Comment 13 2016-08-29 12:14:32 PDT

Created attachment 287303 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 14 2016-08-29 12:15:25 PDT

Comment on attachment 287286 [details] patch Attachment 287286 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1966988 New failing tests: svg/webarchive/svg-cursor-subresources.svg fast/events/mouse-cursor.html

Build Bot

Comment 15 2016-08-29 12:15:29 PDT

Created attachment 287304 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 16 2016-08-29 12:20:44 PDT

Comment on attachment 287286 [details] patch Attachment 287286 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1967003 New failing tests: svg/webarchive/svg-cursor-subresources.svg fast/events/mouse-cursor.html

Build Bot

Comment 17 2016-08-29 12:20:48 PDT

Created attachment 287306 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 18 2016-08-29 12:28:04 PDT

Created attachment 287307 [details] patch

Andreas Kling

Comment 19 2016-08-30 07:42:19 PDT

Comment on attachment 287307 [details] patch r=me

WebKit Commit Bot

Comment 20 2016-08-30 08:08:10 PDT

Comment on attachment 287307 [details] patch Clearing flags on attachment: 287307 Committed r205181: <http://trac.webkit.org/changeset/205181>

WebKit Commit Bot

Comment 21 2016-08-30 08:08:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.