Bug 161197

Summary:

Fix the ENABLE(WEBASSEMBLY) build on Linux

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, ossy

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Csaba Osztrogonác

Reported 2016-08-25 09:59:54 PDT

patch is coming

Attachments
Patch (11.83 KB, patch) 2016-08-25 11:02 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch for landing (11.89 KB, patch) 2016-08-26 08:46 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2016-08-25 10:05:41 PDT

Warnings should be fixed: ../../Source/JavaScriptCore/wasm/WASMModuleParser.cpp: In member function 'bool JSC::WASM::WASMModuleParser::parseFunctionTypes()': ../../Source/JavaScriptCore/wasm/WASMModuleParser.cpp:169:32: warning: variable 'returnType' set but not used [-Wunused-but-set-variable] ../../Source/JavaScriptCore/wasm/WASMB3IRGenerator.cpp: In function 'JSC::B3::Opcode JSC::WASM::toB3Op(JSC::WASM::WASMUnaryOpType)': ../../Source/JavaScriptCore/wasm/WASMB3IRGenerator.cpp:60:1: warning: control reaches end of non-void function [-Wreturn-type] ../../Source/JavaScriptCore/wasm/WASMB3IRGenerator.cpp: In function 'JSC::B3::Opcode JSC::WASM::toB3Op(JSC::WASM::WASMBinaryOpType)': ../../Source/JavaScriptCore/wasm/WASMB3IRGenerator.cpp:51:1: warning: control reaches end of non-void function [-Wreturn-type]

Csaba Osztrogonác

Comment 2 2016-08-25 11:02:14 PDT

Created attachment 286984 [details] Patch Added new files to the build system, fixed build warnings, fixed guards, fixed non FTL JIT build.

Mark Lam

Comment 3 2016-08-25 11:05:58 PDT

Comment on attachment 286984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286984&action=review r=me > Source/JavaScriptCore/wasm/WASMModuleParser.cpp:183 > + (void)returnType; How about using UNUSED_PARAM(returnType) instead?

Csaba Osztrogonác

Comment 4 2016-08-26 08:46:44 PDT

Created attachment 287107 [details] Patch for landing

WebKit Commit Bot

Comment 5 2016-08-26 09:56:01 PDT

Comment on attachment 287107 [details] Patch for landing Clearing flags on attachment: 287107 Committed r205021: <http://trac.webkit.org/changeset/205021>

WebKit Commit Bot

Comment 6 2016-08-26 09:56:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.