Bug 161182

Summary: Add final keyword to final classes and overriden methods in WebCore/css
Product: WebKit Reporter: Rawinder Singh <rawinder.webkit>
Component: CSSAssignee: Rawinder Singh <rawinder.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mcatanzaro, tonikitoo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rawinder Singh
Reported 2016-08-24 20:45:36 PDT
This patch: - Marks classes in the WebCore/css directory final as appropriate. - Updates WebCore/css classes so that overriden methods in final classes are marked final.
Attachments
Patch (65.64 KB, patch)
2016-08-24 20:52 PDT, Rawinder Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rawinder Singh
Comment 1 2016-08-24 20:52:27 PDT
Created attachment 286942 [details] Patch
Darin Adler
Comment 2 2016-08-27 17:19:08 PDT
Comment on attachment 286942 [details] Patch Thanks. Looks good.
WebKit Commit Bot
Comment 3 2016-08-27 17:42:13 PDT
Comment on attachment 286942 [details] Patch Clearing flags on attachment: 286942 Committed r205093: <http://trac.webkit.org/changeset/205093>
WebKit Commit Bot
Comment 4 2016-08-27 17:42:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.