Summary: | [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, darin, lforschler | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 160736 | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2016-08-24 10:40:23 PDT
Created attachment 286869 [details]
Patch
Created attachment 286871 [details]
Patch
trivial: fix identation
Comment on attachment 286871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286871&action=review > Tools/Scripts/run-gtk-tests:155 > + def _wait_for_accessibility_bus(self, timeout=5, env={}): Why are params optional if you are passing them always? If the timeout can't be configured, we don't need to pass it to the function, use 5 directly in GLib.timeout_add_seconds > Tools/Scripts/run-gtk-tests:191 > + if not self._wait_for_accessibility_bus(timeout=5, env=self._test_env): You don't need to use the name=value, just pass the values. But in this case, you are passing a hardcoded value that could be used directly by the function, and a member variable to a member function, so the function could simply use self._test_env Committed r205017: <http://trac.webkit.org/changeset/205017> |