Summary: | [Fetch API] Response cloning should structureClone when teeing Response stream | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, sam | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 151937 | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2016-08-24 10:16:56 PDT
Created attachment 286862 [details]
Patch
Comment on attachment 286862 [details] Patch Attachment 286862 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1935271 New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html Created attachment 286879 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Comment on attachment 286862 [details]
Patch
win and ios-sim failures seem unrelated to this patch.
Created attachment 286965 [details]
Setting correct argument count
Comment on attachment 286965 [details] Setting correct argument count View in context: https://bugs.webkit.org/attachment.cgi?id=286965&action=review > Source/WebCore/bindings/js/StructuredClone.h:28 > +typedef int64_t EncodedJSValue; New code should use "using". > Source/WebCore/bindings/js/StructuredClone.h:35 > +namespace WebCore { > +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBuffer(JSC::ExecState*); > +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBufferView(JSC::ExecState*); > +} // namespace WebCore Should have blank lines inside the namespace. Created attachment 287259 [details]
Patch for landing
Thanks for the review. (In reply to comment #6) > Comment on attachment 286965 [details] > Setting correct argument count > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286965&action=review > > > Source/WebCore/bindings/js/StructuredClone.h:28 > > +typedef int64_t EncodedJSValue; > > New code should use "using". Done > > Source/WebCore/bindings/js/StructuredClone.h:35 > > +namespace WebCore { > > +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBuffer(JSC::ExecState*); > > +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBufferView(JSC::ExecState*); > > +} // namespace WebCore > > Should have blank lines inside the namespace. Done Created attachment 287264 [details]
Patch for landing
Comment on attachment 287264 [details] Patch for landing Clearing flags on attachment: 287264 Committed r205117: <http://trac.webkit.org/changeset/205117> All reviewed patches have been landed. Closing bug. |