Bug 161147 – [Fetch API] Response cloning should structureClone when teeing Response stream

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

As per there spec, structureClone should be used when teeing.
structureClone should be supported in ReadableStream tee.

[youenn fablet]

Created attachment 286862 [details]
Patch

[Build Bot]

Comment on attachment 286862 [details]
Patch

Attachment 286862 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1935271

New failing tests:
fast/scrolling/ios/scrollTo-at-page-load.html

[Build Bot]

Created attachment 286879 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[youenn fablet]

Comment on attachment 286862 [details]
Patch

win and ios-sim failures seem unrelated to this patch.

[youenn fablet]

Created attachment 286965 [details]
Setting correct argument count

[Darin Adler]

Comment on attachment 286965 [details]
Setting correct argument count

View in context: https://bugs.webkit.org/attachment.cgi?id=286965&action=review

> Source/WebCore/bindings/js/StructuredClone.h:28
> +typedef int64_t EncodedJSValue;

New code should use "using".

> Source/WebCore/bindings/js/StructuredClone.h:35
> +namespace WebCore {
> +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBuffer(JSC::ExecState*);
> +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBufferView(JSC::ExecState*);
> +} // namespace WebCore

Should have blank lines inside the namespace.

[youenn fablet]

Created attachment 287259 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to comment #6)
> Comment on attachment 286965 [details]
> Setting correct argument count
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286965&action=review
> 
> > Source/WebCore/bindings/js/StructuredClone.h:28
> > +typedef int64_t EncodedJSValue;
> 
> New code should use "using".

Done

> > Source/WebCore/bindings/js/StructuredClone.h:35
> > +namespace WebCore {
> > +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBuffer(JSC::ExecState*);
> > +JSC::EncodedJSValue JSC_HOST_CALL structuredCloneArrayBufferView(JSC::ExecState*);
> > +} // namespace WebCore
> 
> Should have blank lines inside the namespace.

Done

[youenn fablet]

Created attachment 287264 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 287264 [details]
Patch for landing

Clearing flags on attachment: 287264

Committed r205117: <http://trac.webkit.org/changeset/205117>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.