Bug 161120

Summary: Unused cxxabi.h include in JSGlobalObjectInspectorController.cpp
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161193
Attachments:
Description Flags
Move cxxabi to correct position
none
Move cxxabi to correct position
none
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 none

Don Olmstead
Reported 2016-08-23 17:38:19 PDT
The cxxabi.h is only used on certain platforms but is being included for all.
Attachments
Move cxxabi to correct position (1.28 KB, patch)
2016-08-23 17:40 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Move cxxabi to correct position (1.11 KB, patch)
2016-08-24 17:40 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 (804.39 KB, application/zip)
2016-08-25 04:42 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2016-08-23 17:40:47 PDT
Created attachment 286809 [details] Move cxxabi to correct position
Alexey Proskuryakov
Comment 2 2016-08-24 17:05:45 PDT
Comment on attachment 286809 [details] Move cxxabi to correct position View in context: https://bugs.webkit.org/attachment.cgi?id=286809&action=review This patch is not marked for review, did you intend to mark it? > Source/JavaScriptCore/ChangeLog:62926 > + > + What happened here?
Don Olmstead
Comment 3 2016-08-24 17:40:20 PDT
Created attachment 286922 [details] Move cxxabi to correct position
Don Olmstead
Comment 4 2016-08-24 17:40:54 PDT
(In reply to comment #2) > Comment on attachment 286809 [details] > Move cxxabi to correct position > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286809&action=review > > This patch is not marked for review, did you intend to mark it? > > > Source/JavaScriptCore/ChangeLog:62926 > > + > > + > > What happened here? Editor managed to do that when i was generating the changelog. Fixed in the new attachment.
Build Bot
Comment 5 2016-08-25 04:42:19 PDT
Comment on attachment 286922 [details] Move cxxabi to correct position Attachment 286922 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1939461 New failing tests: fast/viewport/ios/width-is-device-width-overflowing.html
Build Bot
Comment 6 2016-08-25 04:42:21 PDT
Created attachment 286960 [details] Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Alexey Proskuryakov
Comment 7 2016-08-25 09:07:20 PDT
This failure is of course a false positive. Investigating.
WebKit Commit Bot
Comment 8 2016-08-27 17:17:41 PDT
Comment on attachment 286922 [details] Move cxxabi to correct position Clearing flags on attachment: 286922 Committed r205091: <http://trac.webkit.org/changeset/205091>
WebKit Commit Bot
Comment 9 2016-08-27 17:17:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.