Bug 161095

Summary:

Add pref for enabling new CSS parsing and move parser files into subdirectory.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

46591

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Dave Hyatt

Reported 2016-08-23 11:07:10 PDT

Add pref for enabling new CSS parsing and move parser files into subdirectory.

Attachments
Patch (4.52 KB, patch) 2016-08-23 11:07 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (4.52 KB, patch) 2016-08-23 11:10 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (638.08 KB, patch) 2016-08-23 11:12 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (638.39 KB, patch) 2016-08-23 11:17 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (1.22 MB, patch) 2016-08-23 11:23 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2016-08-23 11:07:35 PDT

Created attachment 286739 [details] Patch

Dave Hyatt

Comment 2 2016-08-23 11:10:39 PDT

Created attachment 286741 [details] Patch

Dave Hyatt

Comment 3 2016-08-23 11:12:25 PDT

Created attachment 286743 [details] Patch

Dave Hyatt

Comment 4 2016-08-23 11:17:14 PDT

Created attachment 286745 [details] Patch

WebKit Commit Bot

Comment 5 2016-08-23 11:18:51 PDT

Attachment 286745 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:1348: There should be exactly one empty line instead of 0 between "css/CSSPageRule.cpp" and "css/parser/CSSParser.cpp". [list/emptyline] [5] ERROR: Source/WebCore/CMakeLists.txt:1393: There should be exactly one empty line instead of 0 between "css/SVGCSSComputedStyleDeclaration.cpp" and "css/parser/SVGCSSParser.cpp". [list/emptyline] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 6 2016-08-23 11:23:34 PDT

Created attachment 286746 [details] Patch

WebKit Commit Bot

Comment 7 2016-08-23 11:25:58 PDT

Attachment 286746 [details] did not pass style-queue: ERROR: Source/WebCore/css/parser/CSSParser.h:242: 'parseGridTrackList' is incorrectly named. It should be named 'protector' or 'protectedTrackListType'. [readability/naming/protected] [4] ERROR: Source/WebCore/css/parser/CSSParser.h:261: 'parseShapeProperty' is incorrectly named. It should be named 'protector' or 'protectedCSSPropertyID'. [readability/naming/protected] [4] ERROR: Source/WebCore/css/parser/CSSParser.h:692: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/css/parser/CSSParser.h:730: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParserValues.h:119: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/parser/CSSParserValues.cpp:25: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:168: MAX_SCALE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:616: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:617: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:618: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:798: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:799: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:800: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:808: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:828: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1708: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1717: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1909: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1903: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1947: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1950: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1966: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:1973: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2028: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2020: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2040: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2066: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2068: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2133: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2202: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2202: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2203: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2204: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2216: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2239: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2240: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2241: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2255: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2262: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2273: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2274: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2275: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2276: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2276: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2318: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2319: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2320: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2321: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2322: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2323: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2324: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2325: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2325: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2336: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2353: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2358: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2809: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2801: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2820: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2820: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2873: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:2963: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:3612: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:3615: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:3777: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:3996: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4045: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4074: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4074: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4099: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4102: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4315: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4435: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4698: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4707: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4711: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4727: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4825: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:4864: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:5063: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:5143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:5342: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:6205: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:6284: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:6502: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:6514: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:7103: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:7104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:7105: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:7106: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:7145: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:7155: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:7916: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8047: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8053: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8064: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8083: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8087: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8089: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8196: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8197: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8198: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8199: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8200: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8201: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8202: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8203: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8204: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8428: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/W ebCore/css/parser/CSSParser.cpp:8429: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8430: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8431: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8432: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8543: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8544: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8545: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8749: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8757: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8875: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8878: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8908: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8910: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8919: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8949: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:8958: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9014: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9637: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9770: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9784: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9796: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9797: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9798: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9811: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9822: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9832: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9833: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9834: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9835: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9836: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9852: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9864: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9865: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9866: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9867: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9868: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9869: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9885: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9898: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9899: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9900: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9901: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9902: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9903: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9904: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9905: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9913: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9931: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9956: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9971: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9973: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9974: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9975: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9976: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9977: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9978: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9979: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9980: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:9981: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:10122: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:12077: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:12109: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:12129: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:12184: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:12203: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:12617: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParser.cpp:13258: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:13576: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:13657: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/CSSParser.cpp:13734: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:49: valid_primitive is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:292: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:59: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:59: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:66: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:66: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:77: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:77: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:78: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:102: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:108: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:112: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:117: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:122: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:131: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:131: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:137: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:137: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:152: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:162: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:188: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:189: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:246: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:254: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:261: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:324: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:347: valid_primitive is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/css/parser/SVGCSSParser.cpp:354: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 219 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 8 2016-08-23 11:27:45 PDT

rs=me on the moves, r=me on the settings changes, when it builds.

Dave Hyatt

Comment 9 2016-08-23 12:40:03 PDT

Landed in r204852.

Note You need to log in before you can comment on or make changes to this bug.