Bug 161089 – Add support for CanvasRenderingContext2D.resetTransform()

• Component: Canvas
• Status: RESOLVED FIXED

[Chris Dumez]

Add support for CanvasRenderingContext2D.resetTransform():
- https://html.spec.whatwg.org/#dom-context-2d-resettransform

Firefox and Chrome already support this.

[Chris Dumez]

Created attachment 286724 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 286724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286724&action=review

> LayoutTests/imported/w3c/ChangeLog:11
> +        * web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001-expected.html: Added.
> +        * web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001.html: Added.
> +        Import W3C test to cover CanvasRenderingContext2D.resetTransform().
> +

Would be nice to have a test that tests this across save/restore.

[Build Bot]

Comment on attachment 286724 [details]
Patch

Attachment 286724 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1928645

New failing tests:
imported/w3c/web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001.html

[Build Bot]

Created attachment 286748 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Said Abou-Hallawa]

Comment on attachment 286724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286724&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:821
>      if (!ctm.isInvertible())

Can't we use if (!state().hasInvertibleTransform) instead?

[Chris Dumez]

(In reply to comment #5)
> Comment on attachment 286724 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286724&action=review
> 
> > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:821
> >      if (!ctm.isInvertible())
> 
> Can't we use if (!state().hasInvertibleTransform) instead?

I have merely moved the existing code but I will check.

[Said Abou-Hallawa]

Comment on attachment 286724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286724&action=review

>>> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:821
>>>      if (!ctm.isInvertible())
>> 
>> Can't we use if (!state().hasInvertibleTransform) instead?
> 
> I have merely moved the existing code but I will check.

state().hasInvertibleTransform is a cached value for state().isInvertible() since the later is an expensive operation.

[Chris Dumez]

Created attachment 286799 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 286799 [details]
Patch

Clearing flags on attachment: 286799

Committed r204878: <http://trac.webkit.org/changeset/204878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Anne van Kesteren]

*** Bug 149988 has been marked as a duplicate of this bug. ***