Bug 161088

Summary: [Resource Timing] Resource Timing tests fails under some conditions
Product: WebKit Reporter: Johan K. Jensen <jj>
Component: Tools / TestsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, buildbot, commit-queue, joepeck, lforschler, rniwa, ryanhaddad, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Work in Progress
buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-elcapitan
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews103 for mac-elcapitan none

Description Johan K. Jensen 2016-08-23 10:02:40 PDT
The Resource Timing tests included as part of the W3C Web Platform Tests are flaky under an upcoming patch for issue 161068.
The tests fails under these two circumstances:

1)
When PerformanceResourceTiming is created with a null ResourceResponse. This happens when memoryCache.resourceForRequest(..) (inside CachedResourceLoader::requestResource) returns a resource whose response (resource->response()) is null.

2)
When the onreadystatechange callback of an XHR or the onload callback of an added stylesheet is called, before the resource timing entry has been added to the timeline.

The imported/w3c/web-platform-tests/resource-timing/resource-timing.html test will occasionally run into one of the above cases and fail the test.
Comment 1 Joseph Pecoraro 2017-02-09 16:20:17 PST
Created attachment 301098 [details]
[PATCH] Work in Progress

I need to write tests, but I'm using the bots to check existing tests and other ports on this patch while I tackle initial test cleanup and start adding tests for workers.
Comment 2 WebKit Commit Bot 2017-02-09 16:22:33 PST
Attachment 301098 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/DocumentThreadableLoader.cpp:52:  "ResourceTiming.h" already included at Source/WebCore/loader/DocumentThreadableLoader.cpp:51  [build/include] [4]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2017-02-09 17:22:35 PST
Comment on attachment 301098 [details]
[PATCH] Work in Progress

Attachment 301098 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3053385

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2017-02-09 17:22:38 PST
Created attachment 301109 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-02-09 17:33:29 PST
Comment on attachment 301098 [details]
[PATCH] Work in Progress

Attachment 301098 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3053411

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2017-02-09 17:33:32 PST
Created attachment 301112 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-02-09 17:35:29 PST
Comment on attachment 301098 [details]
[PATCH] Work in Progress

Attachment 301098 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3053444

New failing tests:
js/dom/global-constructors-attributes.html
imported/w3c/web-platform-tests/resource-timing/resource_cached.htm
http/tests/preload/dynamic_removing_preload.html
js/dom/global-constructors-attributes-dedicated-worker.html
imported/w3c/web-platform-tests/resource-timing/resource_connection_reuse.html
Comment 8 Build Bot 2017-02-09 17:35:32 PST
Created attachment 301113 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-02-10 02:13:53 PST
Comment on attachment 301098 [details]
[PATCH] Work in Progress

Attachment 301098 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3061460

New failing tests:
http/tests/preload/dynamic_removing_preload.html
performance-api/resource-timing-apis.html
imported/w3c/web-platform-tests/resource-timing/resource_connection_reuse.html
imported/w3c/web-platform-tests/resource-timing/resource_cached.htm
Comment 10 Build Bot 2017-02-10 02:13:57 PST
Created attachment 301141 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Joseph Pecoraro 2017-02-16 11:10:10 PST
Oops, this patch was meant for another bug. Either way, I can take this.
Comment 12 Joseph Pecoraro 2017-03-27 13:17:20 PDT
I believe I've addressed these cases.