Bug 161085 – It should be easy to run ES6SampleBench from the jsc shell

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Saam Barati]

I was thinking it should be as easy as:
`jsc cli.js`

[Saam Barati]

Created attachment 286769 [details]
patch

[Saam Barati]

The output from running this looks like:
...
...
...
...
...
...
...
Running... Air ( 10  to go)
firstIteration:     95.44 ms
averageWorstCase:   25.74 ms
steadyState:        2067.60 ms
...


Running... Basic ( 10  to go)
firstIteration:     28.15 ms
averageWorstCase:   22.01 ms
steadyState:        2808.30 ms
summary:            143.79 ms


Running... Air ( 9  to go)
firstIteration:     78.92 ms
averageWorstCase:   27.99 ms
steadyState:        2121.57 ms
summary:            143.79 ms


Running... Basic ( 9  to go)
firstIteration:     26.69 ms
averageWorstCase:   26.14 ms
steadyState:        2921.91 ms
summary:            144.69 ms


Running... Air ( 8  to go)
firstIteration:     70.13 ms +- 55.76 ms
averageWorstCase:   32.19 ms +- 18.88 ms
steadyState:        2209.58 ms +- 401.50 ms
summary:            144.69 ms


Running... Basic ( 8  to go)
firstIteration:     28.21 ms +- 7.48 ms
averageWorstCase:   24.31 ms +- 12.92 ms
steadyState:        2943.24 ms +- 296.59 ms
summary:            145.23 ms +- 3.22 ms


Running... Air ( 7  to go)
firstIteration:     66.45 ms +- 31.42 ms
averageWorstCase:   32.14 ms +- 9.87 ms
steadyState:        2203.60 ms +- 210.81 ms
summary:            145.23 ms +- 3.22 ms


Running... Basic ( 7  to go)
firstIteration:     28.85 ms +- 4.41 ms
averageWorstCase:   23.39 ms +- 7.37 ms
steadyState:        2934.66 ms +- 157.48 ms
summary:            143.61 ms +- 5.40 ms


Running... Air ( 6  to go)
firstIteration:     64.28 ms +- 22.11 ms
averageWorstCase:   32.93 ms +- 7.04 ms
steadyState:        2245.04 ms +- 183.44 ms
summary:            143.61 ms +- 5.40 ms


Running... Basic ( 6  to go)
firstIteration:     28.45 ms +- 3.19 ms
averageWorstCase:   23.67 ms +- 5.05 ms
steadyState:        2893.28 ms +- 156.87 ms
summary:            143.62 ms +- 3.66 ms


Running... Air ( 5  to go)
firstIteration:     61.94 ms +- 17.75 ms
averageWorstCase:   33.56 ms +- 5.56 ms
steadyState:        2235.83 ms +- 140.47 ms
summary:            143.62 ms +- 3.66 ms


Running... Basic ( 5  to go)
firstIteration:     28.03 ms +- 2.64 ms
averageWorstCase:   23.34 ms +- 3.91 ms
steadyState:        2899.33 ms +- 119.43 ms
summary:            142.54 ms +- 3.92 ms


Running... Air ( 4  to go)
firstIteration:     62.82 ms +- 14.46 ms
averageWorstCase:   34.01 ms +- 4.61 ms
steadyState:        2241.81 ms +- 114.12 ms
summary:            142.54 ms +- 3.92 ms


Running... Basic ( 4  to go)
firstIteration:     27.59 ms +- 2.38 ms
averageWorstCase:   22.55 ms +- 3.69 ms
steadyState:        2866.58 ms +- 125.28 ms
summary:            141.82 ms +- 3.61 ms


Running... Air ( 3  to go)
firstIteration:     60.50 ms +- 13.25 ms
averageWorstCase:   33.64 ms +- 3.95 ms
steadyState:        2221.61 ms +- 106.46 ms
summary:            141.82 ms +- 3.61 ms


Running... Basic ( 3  to go)
firstIteration:     27.37 ms +- 2.05 ms
averageWorstCase:   22.36 ms +- 3.11 ms
steadyState:        2844.22 ms +- 117.09 ms
summary:            139.96 ms +- 5.34 ms


Running... Air ( 2  to go)
firstIteration:     59.19 ms +- 11.83 ms
averageWorstCase:   33.12 ms +- 3.61 ms
steadyState:        2201.29 ms +- 103.20 ms
summary:            139.96 ms +- 5.34 ms


Running... Basic ( 2  to go)
firstIteration:     27.11 ms +- 1.87 ms
averageWorstCase:   21.93 ms +- 2.87 ms
steadyState:        2825.77 ms +- 109.69 ms
summary:            138.13 ms +- 6.24 ms


Running... Air ( 1  to go)
firstIteration:     57.71 ms +- 10.88 ms
averageWorstCase:   33.09 ms +- 3.16 ms
steadyState:        2189.60 ms +- 94.09 ms
summary:            138.13 ms +- 6.24 ms


Running... Basic ( 1  to go)
firstIteration:     26.93 ms +- 1.69 ms
averageWorstCase:   21.74 ms +- 2.55 ms
steadyState:        2824.91 ms +- 96.01 ms
summary:            137.10 ms +- 5.95 ms
Success! Benchmark is now finished.

[Yusuke Suzuki]

Comment on attachment 286769 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286769&action=review

r=me. It is good for testing.

> PerformanceTests/ES6SampleBench/driver.js:124
> +                        ` <a href="${this._triggerLink}">Restart Benchmark</a>`;

Is it OK not to show success/failure in browser mode?

> PerformanceTests/ES6SampleBench/stats.js:112
> +        }

Let's drop braces here.

> PerformanceTests/ES6SampleBench/Air/util.js:172
> +var currentTime;

Why is it changed?

> PerformanceTests/ES6SampleBench/Basic/util.js:27
> +var currentTime;

Ditto.

[Saam Barati]

Comment on attachment 286769 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286769&action=review

>> PerformanceTests/ES6SampleBench/driver.js:124
>> +                        ` <a href="${this._triggerLink}">Restart Benchmark</a>`;
> 
> Is it OK not to show success/failure in browser mode?

Oops, that was unintentional. I'll add that back to the browser path as well.

>> PerformanceTests/ES6SampleBench/stats.js:112
>> +        }
> 
> Let's drop braces here.

will do

>> PerformanceTests/ES6SampleBench/Air/util.js:172
>> +var currentTime;
> 
> Why is it changed?

Oops^2. This was from a previous iteration of the patch where both benchmarks were executed in the same scope, so their
definitions were throwing an early error from duplicate declarations. I think I can revert them back to `let`.

[Saam Barati]

Created attachment 286812 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 286812 [details]
patch for landing

Clearing flags on attachment: 286812

Committed r204882: <http://trac.webkit.org/changeset/204882>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.