Bug 161074

Summary: Order feature option list in FeatureList.pm
Product: WebKit Reporter: Rawinder Singh <rawinder.webkit>
Component: WebKit Misc.Assignee: Rawinder Singh <rawinder.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rawinder Singh
Reported 2016-08-22 21:54:40 PDT
The order of some of the items in the feature list seems a bit arbitary. There are 3 possible ways to sort the list: 1. By the command line option argument (e.g. "generators"). 2. By the description (e.g. "Toggle ES6 generators support"). 3. By the definition (e.g. ENABLE_ES6_GENERATORS). This patch reorders the features based on the command line option, this seems more intuitive to me (e.g. when the options are printed in the --help message).
Attachments
Patch (15.01 KB, patch)
2016-08-22 22:01 PDT, Rawinder Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rawinder Singh
Comment 1 2016-08-22 22:01:46 PDT
Created attachment 286671 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-23 06:41:12 PDT
Comment on attachment 286671 [details] Patch Clearing flags on attachment: 286671 Committed r204831: <http://trac.webkit.org/changeset/204831>
WebKit Commit Bot
Comment 3 2016-08-23 06:41:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.