Summary: | REGRESSION (r201454): Web Inspector: Text caret isn't visible when editing an attribute | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Critical | CC: | bburg, commit-queue, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||||
Priority: | P1 | Keywords: | GoodFirstBug, InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2016-08-18 17:11:42 PDT
Created attachment 286420 [details]
[Animated GIF] Bug
I think this was partially caused by <webkit.org/b/157468> (r279944). The z-index change of the `.tree-outline.dom li .selection-area` element, as well as the background-color of `.editing`, seem to prevent the text caret from being visible (it is shown, but it is below the background of `.tree-outline.dom li .selection-area` AND `.editing`). Might also be an HTML issue. This was indeed broken by http://trac.webkit.org/changeset/201454. Created attachment 287572 [details]
WIP
Created attachment 287574 [details]
Patch
Created attachment 287577 [details]
[Animated GIF] With patch applied
This patch has a side-effect. The nesting indicator now overlays the selected element. I personally don't mind that.
Comment on attachment 287574 [details] Patch Somewhat unrelated, but I think that we should make the editing cursor a text-bar, not just a regular cursor. You can change this in Editing.css: .editing, .editing * { color: black !important; text-decoration: none !important; cursor: text !important; } View in context: https://bugs.webkit.org/attachment.cgi?id=287574&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:68 > z-index: 20; If you are removing `position: relative;` you should remove the z-index. It is ignored if the position is static. Comment on attachment 287577 [details]
[Animated GIF] With patch applied
The "after" gif doesn't show the text caret. Did you forget?
Created attachment 287644 [details]
[Animated GIF] With patch applied, text caret is visible
Created attachment 287645 [details]
Patch
Comment on attachment 287645 [details]
Patch
r=me
Comment on attachment 287645 [details] Patch Clearing flags on attachment: 287645 Committed r205307: <http://trac.webkit.org/changeset/205307> All reviewed patches have been landed. Closing bug. |