Bug 160976

Summary: ScopedArguments is using the wrong owner object for a write barrier.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2016-08-18 14:45:03 PDT
Will fix.
Attachments
proposed patch. (3.38 KB, patch)
2016-08-18 14:52 PDT, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-08-18 14:47:23 PDT
<rdar://problem/27328506>
Mark Lam
Comment 2 2016-08-18 14:52:28 PDT
Created attachment 286401 [details] proposed patch.
Keith Miller
Comment 3 2016-08-18 15:05:56 PDT
Comment on attachment 286401 [details] proposed patch. r=me.
Mark Lam
Comment 4 2016-08-18 15:24:12 PDT
Comment on attachment 286401 [details] proposed patch. Cancelling commit for now while I investigate an issue.
Mark Lam
Comment 5 2016-08-18 15:54:44 PDT
Comment on attachment 286401 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286401&action=review > JSTests/stress/scoped-arguments-write-barrier-should-be-on-scope-object.js:1 > +//@ runDefault. Turns out that the test harness doesn't like the period at the end of this line. I will remove it locally and I land this patch manually.
Mark Lam
Comment 6 2016-08-18 15:57:20 PDT
Landed in r204612: <http://trac.webkit.org/r204612>.
Note You need to log in before you can comment on or make changes to this bug.