Bug 160952

Summary: Wrapper for an adopted node can be created in inconsistent global objects
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: BindingsAssignee: Ryosuke Niwa <rniwa>
Status: NEW ---    
Severity: Normal CC: cdumez, ggaren, keith_miller, mjs, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Ryosuke Niwa 2016-08-17 18:30:29 PDT
When a node is adopted into another document without first having a JS wrapper,
its wrapper could be created in either the original document's or new document's global object
depending on how those nodes are accessed.
Comment 1 Ryosuke Niwa 2016-08-17 18:30:52 PDT
Created attachment 286353 [details]
Comment 2 Ryosuke Niwa 2016-08-17 18:36:05 PDT
In this demo, a div element is created in document A, and span and b elements are created as descendants of the div via div.innerHTML. The div is then adopted into another document B.

When accessing the span and the b elements in document B, the manner of accessing those nodes determine the global object in which the wrappers are created.  If we're creating via .firstChild or any other property or any method of the div, then we'd create a wrapper using document A's global object.  If it's done via properties or methods on any other object whose global object is that of document B, then we'd create a wrapper using the global object of document B.
Comment 3 Geoffrey Garen 2016-08-18 16:18:31 PDT
I think the best way to fix this is probably to eagerly reify all wrappers when adopting a node between documents.
Comment 4 Ryosuke Niwa 2016-08-22 14:56:03 PDT
Created attachment 286622 [details]
Comment 5 Ryosuke Niwa 2016-08-22 14:56:28 PDT
Comment on attachment 286622 [details]

Oops, wrong bug.