Bug 160949

Summary: [Win] Remove old libraries from build inputs
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, dbates, ddkilzer, dino
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Windows 10   
Bug Depends on:    
Bug Blocks: 160904    
Attachments:
Description Flags
Patch dino: review+

Brent Fulgham
Reported 2016-08-17 15:05:28 PDT
For historical reasons, WebKit builds on Windows used "icuuc.lib" and "icuin.lib" as the names of the ICU libraries. At some point, these were changed to "libicuuc.lib" and "libicuin.lib" and the build system modified to use them. The updates in Bug 160904 use CMake's 'find_library' utility to locate the ICU locations. Unfortunately, on some build bots this logic finds the old copies of icuuc/icuin and attempts to use them to perform the build, causing a failure. This patch updates the "update-webkit-auxiliary-libraries" script to remove these two files when running on Windows or Cygwin. It does not change the behavior of the WinCairo build or other platforms.
Attachments
Patch (1.74 KB, patch)
2016-08-17 15:14 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-08-17 15:14:15 PDT
Created attachment 286333 [details] Patch
Brent Fulgham
Comment 2 2016-08-17 16:10:02 PDT
Committed r204580: <http://trac.webkit.org/changeset/204580>
Note You need to log in before you can comment on or make changes to this bug.