| Summary: | Remove StyleCachedImageSet | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, bdakin, buildbot, dino, ossy, rniwa, simon.fraser | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Antti Koivisto
2016-08-17 07:21:44 PDT
Created attachment 286297 [details]
patch
Comment on attachment 286297 [details] patch Attachment 286297 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1887539 New failing tests: fast/events/mouse-cursor-image-set.html Created attachment 286299 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 286297 [details] patch Attachment 286297 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1887550 New failing tests: fast/events/mouse-cursor-image-set.html Created attachment 286300 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 286301 [details]
patch
Comment on attachment 286301 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=286301&action=review > Source/WebCore/rendering/style/StyleCachedImage.h:40 > + static Ref<StyleCachedImage> createForImageSet(CachedImage* image, float scaleFactor, CSSImageSetValue& cssValue) { return adoptRef(*new StyleCachedImage(image, scaleFactor, &cssValue)); } What is scaleFactor? a deviceScaleFactor, or something else? > What is scaleFactor? a deviceScaleFactor, or something else?
It is the scale factor of the best-fit image in an image set, picked based on deviceScaleFactor.
(In reply to comment #9) > https://trac.webkit.org/r204560 It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/rendering/style/StyleCachedImage.cpp:50:16: error: no viable conversion from 'WebCore::CSSImageSetValue *' to 'PassRefPtr<WebCore::CSSValue>' return const_cast<CSSImageSetValue*>(m_cssImageSetValue); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:49:9: note: candidate constructor not viable: cannot convert argument of incomplete type 'WebCore::CSSImageSetValue *' to 'WebCore::CSSValue *' PassRefPtr(T* ptr) : m_ptr(ptr) { refIfNotNull(ptr); } ^ /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:53:9: note: candidate constructor not viable: cannot convert argument of incomplete type 'WebCore::CSSImageSetValue *' to 'const WTF::PassRefPtr<WebCore::CSSValue> &' PassRefPtr(const PassRefPtr& o) : m_ptr(o.leakRef()) { } ^ /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:54:30: note: candidate template ignored: could not match 'PassRefPtr<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *' template<typename U> PassRefPtr(const PassRefPtr<U>& o) : m_ptr(o.leakRef()) { } ^ /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:58:30: note: candidate template ignored: could not match 'RefPtr<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *' template<typename U> PassRefPtr(const RefPtr<U>&); ^ /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:59:30: note: candidate template ignored: could not match 'Ref<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *' template<typename U> PassRefPtr(Ref<U>&& reference) : m_ptr(&reference.leakRef()) { } ^ /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:60:30: note: candidate template ignored: could not match 'RefPtr<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *' template<typename U> PassRefPtr(RefPtr<U>&& reference) : m_ptr(reference.leakRef()) { } https://trac.webkit.org/r204564 should help |