Bug 160927 – [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

On r203674 and r203677 a script was added to write to disk the coredumps generated by the WebKit tests.

However, this script is not really needed, because the kernel itself can take care of writing the coredumps to disk directly.

Relying on the kernel core dumper to write the cores to disk has some advantages:

 * Simplifies the handling of coredumps.
 * Avoids running as root a script.
 * The coredump file gets written to disk as the user running the tests, rather than as root.
 * Avoids potential race conditions. On the WebKit Debug bot I found that sometimes when GDB was executed the coredump was still not 100% fully written to disk, and therefore GDB failed with an error saying that the core was truncated. Probably this could be fixed by setting the sysctl core_pipe_limit to a non-zero value. But to seems simpler and safer not piping to a program/script if its not really needed. Since I switched the GTK Debug bot to use the kernel coredumper rather than piping to the script process-linux-coredump I have not found this issue again.

[Carlos Alberto Lopez Perez]

Created attachment 286244 [details]
Patch

[Daniel Bates]

Comment on attachment 286244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286244&action=review

> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:80
> +            core_pattern = os.path.join(log_directory, "core-pid_%p.dump")

We should use Filesystem.join() instead of os.path.join() directly.

> Tools/Scripts/webkitpy/port/linux_get_crash_log_unittest.py:47
> +        core_pattern = os.path.join(core_directory, "core-pid_%p.dump")

Ditto.

[Carlos Alberto Lopez Perez]

Committed r204727: <http://trac.webkit.org/changeset/204727>