Bug 160924

Summary: prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, lforschler, slewis
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 148437    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2016-08-16 17:25:16 PDT
As a step towards writing tests to ensure the correctness of the the list of modified functions we should extract the logic in generateFunctionLists(), abstracting file system operations, such that we can substitute mock file handles and test the implementation of this function.
Attachments
Patch (7.72 KB, patch)
2016-08-16 17:59 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-08-16 17:59:39 PDT
Created attachment 286241 [details] Patch
Daniel Bates
Comment 2 2016-08-16 19:32:02 PDT
Comment on attachment 286241 [details] Patch Clearing flags on attachment: 286241 Committed r204549: <http://trac.webkit.org/changeset/204549>
Daniel Bates
Comment 3 2016-08-16 19:32:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.