Bug 160916

Summary: Enable WebAssembly in the build.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cgarcia, cmarcelo, commit-queue, gyuyoung.kim, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keith Miller
Reported 2016-08-16 15:13:42 PDT
Enable WebAssembly in the build.
Attachments
Patch (1.49 KB, patch)
2016-08-16 15:20 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2016-08-16 15:59 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2016-08-16 16:05 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-08-16 15:20:07 PDT
Created attachment 286215 [details] Patch
Keith Miller
Comment 2 2016-08-16 15:59:26 PDT
Created attachment 286222 [details] Patch
Keith Miller
Comment 3 2016-08-16 16:05:29 PDT
Created attachment 286223 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-16 17:00:54 PDT
Comment on attachment 286223 [details] Patch Clearing flags on attachment: 286223 Committed r204541: <http://trac.webkit.org/changeset/204541>
WebKit Commit Bot
Comment 5 2016-08-16 17:00:58 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2016-12-16 03:20:36 PST
Comment on attachment 286223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286223&action=review > Source/WTF/ChangeLog:10 > + This patch turns on WebAssembly on all the platforms that support B3. > + Turning on WebAssembly by default lets us check the build on every > + platform. This comment isn't true, it enabled wasm only on iOS and Mac platforms.
Keith Miller
Comment 7 2016-12-16 09:25:17 PST
(In reply to comment #6) > Comment on attachment 286223 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286223&action=review > > > Source/WTF/ChangeLog:10 > > + This patch turns on WebAssembly on all the platforms that support B3. > > + Turning on WebAssembly by default lets us check the build on every > > + platform. > > This comment isn't true, it enabled wasm only on iOS and Mac platforms. I suppose the comment should say it is enabled on every platform that supports B3. Since we don't have any way to generate Wasm without B3 it wouldn't do any good to build WebAssembly on those platforms.
Csaba Osztrogonác
Comment 8 2016-12-19 08:45:27 PST
(In reply to comment #7) > (In reply to comment #6) > > Comment on attachment 286223 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=286223&action=review > > > > > Source/WTF/ChangeLog:10 > > > + This patch turns on WebAssembly on all the platforms that support B3. > > > + Turning on WebAssembly by default lets us check the build on every > > > + platform. > > > > This comment isn't true, it enabled wasm only on iOS and Mac platforms. > > I suppose the comment should say it is enabled on every platform that > supports B3. Since we don't have any way to generate Wasm without B3 it > wouldn't do any good to build WebAssembly on those platforms. It's not true. B3-FTL JIT is enabled on X86_64 Linux (not on ARM64 Linux), but WebAssembly is still disabled on all Linux platforms: GTK, EFL and JSCOnly.
Note You need to log in before you can comment on or make changes to this bug.