Bug 160906 – querySelector() / querySelectorAll() should always throw a SyntaxError when failing to parse selector string

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

querySelector() / querySelectorAll() should always throw a SyntaxError when failing to parse selector string:
- https://dom.spec.whatwg.org/#dom-parentnode-queryselector
- https://dom.spec.whatwg.org/#scope-match-a-selectors-string

In some cases, WebKit was throwing a NamespaceError instead.

[Chris Dumez]

Created attachment 286194 [details]
Patch

[Ryosuke Niwa]

This seems like a risky change.

[Chris Dumez]

(In reply to comment #2)
> This seems like a risky change.

? Throwing a different exception type ?

[Ryosuke Niwa]

Comment on attachment 286194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286194&action=review

> Source/WebCore/dom/SelectorQuery.cpp:634
> -        ec = NAMESPACE_ERR;
> +        ec = SYNTAX_ERR;

Oh, you're just changing the exception type.

[WebKit Commit Bot]

Comment on attachment 286194 [details]
Patch

Clearing flags on attachment: 286194

Committed r204522: <http://trac.webkit.org/changeset/204522>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.