Bug 160842

Summary: Allow using make-dist with non-GTK ports
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gyuyoung.kim, lforschler, mcatanzaro, mrobinson
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-08-13 13:32:31 PDT
We are successfully using make-dist.py in Qt port, and from IRC discussion with Gyuyoung Kim I've learned that EFl port is also interested in trying out this tool. This patch adds support for setting base name of tarball and argument passed to cmake's -DPORT= via command line arguments.
Attachments
Patch (3.99 KB, patch)
2016-08-13 13:47 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-08-13 13:47:04 PDT
Created attachment 286005 [details] Patch
Michael Catanzaro
Comment 2 2016-08-15 01:36:27 PDT
Comment on attachment 286005 [details] Patch Please move it out of the gtk subdirectory, to Tools/Scripts, get rid of the gtk defaults, and update whatever it is in the GTK build that calls these scripts to pass in the GTK-specific paths.
Konstantin Tokarev
Comment 3 2016-08-15 02:36:00 PDT
I'll do it in a separate patch
WebKit Commit Bot
Comment 4 2016-08-15 02:57:52 PDT
Comment on attachment 286005 [details] Patch Clearing flags on attachment: 286005 Committed r204460: <http://trac.webkit.org/changeset/204460>
WebKit Commit Bot
Comment 5 2016-08-15 02:57:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.