Bug 160839

Summary:

Remove unused includes of wtf headers

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
Patch	none
Patch	none
Patch	achristensen: review+

Joseph Pecoraro

Reported 2016-08-12 19:27:32 PDT

Remove unused includes of wtf headers. 509 files changed, 51 insertions(+), 581 deletions(-)

Attachments
[PATCH] Proposed Fix (221.39 KB, patch) 2016-08-12 19:35 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Patch (227.00 KB, patch) 2016-08-15 08:31 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (227.08 KB, patch) 2016-08-15 09:19 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (227.79 KB, patch) 2016-08-15 10:11 PDT, Alex Christensen	achristensen: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-08-12 19:35:02 PDT

Created attachment 285999 [details] [PATCH] Proposed Fix cq- to ensure the bots run through it.

Alex Christensen

Comment 2 2016-08-15 08:31:24 PDT

Created attachment 286056 [details] Patch

WebKit Commit Bot

Comment 3 2016-08-15 08:33:11 PDT

Attachment 286056 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/StyleBackgroundData.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitBatteryProvider.h" ERROR: Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/style/StyleBoxData.h:31: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.h" ERROR: Source/WebCore/page/PerformanceNavigation.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/GlyphPage.h:37: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.h" ERROR: Source/WebCore/page/PerformanceTiming.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/WebKitSubtleCrypto.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/Screen.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 11 in 59 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 4 2016-08-15 09:19:26 PDT

Created attachment 286057 [details] Patch

WebKit Commit Bot

Comment 5 2016-08-15 09:20:48 PDT

Attachment 286057 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/StyleBackgroundData.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitBatteryProvider.h" ERROR: Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/style/StyleBoxData.h:31: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.h" ERROR: Source/WebCore/page/PerformanceNavigation.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/GlyphPage.h:37: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.h" ERROR: Source/WebCore/page/PerformanceTiming.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/WebKitSubtleCrypto.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/Screen.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 11 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 6 2016-08-15 10:11:16 PDT

Created attachment 286062 [details] Patch

WebKit Commit Bot

Comment 7 2016-08-15 10:13:52 PDT

Attachment 286062 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/StyleBackgroundData.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitBatteryProvider.h" ERROR: Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/style/StyleBoxData.h:31: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.h" ERROR: Source/WebCore/page/PerformanceNavigation.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/GlyphPage.h:37: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.h" ERROR: Source/WebCore/page/PerformanceTiming.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/WebKitSubtleCrypto.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/Screen.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 11 in 61 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 8 2016-08-15 10:23:53 PDT

Comment on attachment 286062 [details] Patch https://trac.webkit.org/changeset/204466 Will watch for the build breaks that this probably caused.

Note You need to log in before you can comment on or make changes to this bug.