Bug 160824

Summary: Make URLParser work with URLs missing URL parts
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch beidson: review+

Alex Christensen
Reported 2016-08-12 14:49:04 PDT
Make URLParser work with URLs missing URL parts
Attachments
Patch (17.39 KB, patch)
2016-08-12 14:50 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.42 KB, patch)
2016-08-12 16:10 PDT, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-08-12 14:50:42 PDT
Created attachment 285956 [details] Patch
Alex Christensen
Comment 2 2016-08-12 15:51:03 PDT
Comment on attachment 285956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285956&action=review > Source/WebCore/platform/URLParser.cpp:116 > + url.m_protocolIsInHTTPFamily = equalIgnoringASCIICase(urlScheme, "http") || equalIgnoringASCIICase(urlScheme, "https"); This can be a case-sensitive comparison because it is always lower case.
Brady Eidson
Comment 3 2016-08-12 16:04:35 PDT
Comment on attachment 285956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285956&action=review > Source/WebCore/platform/URLParser.cpp:65 > - enum class State : uint8_t { > + enum State { Leave enum class, please. > Source/WebCore/platform/URLParser.cpp:68 > SchemeEndCheckForSlashes, // Scheme state steps 2. 8. Now's a good time to remove this comment.
Alex Christensen
Comment 4 2016-08-12 16:10:09 PDT
Created attachment 285970 [details] Patch
Alex Christensen
Comment 5 2016-08-12 16:36:41 PDT
https://trac.webkit.org/changeset/204431
Note You need to log in before you can comment on or make changes to this bug.