Summary: | Make variant only available when compiling for C++14 or greater | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, ossy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2016-08-12 12:30:52 PDT
Created attachment 285931 [details]
Patch
Created attachment 285932 [details]
Patch
Comment on attachment 285932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285932&action=review > Source/WTF/wtf/StdLibExtras.h:406 > +#if !COMPILER(CLANG) || WTF_CPP_STD_VER < 14 Don't you want >= here? Created attachment 285933 [details]
Patch
(In reply to comment #3) > Comment on attachment 285932 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285932&action=review > > > Source/WTF/wtf/StdLibExtras.h:406 > > +#if !COMPILER(CLANG) || WTF_CPP_STD_VER < 14 > > Don't you want >= here? Ugh, yes. Why do we need this change? I thought c++14 is already mandatory. Created attachment 285958 [details]
Patch
Comment on attachment 285958 [details] Patch Clearing flags on attachment: 285958 Committed r204433: <http://trac.webkit.org/changeset/204433> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > Why do we need this change? I thought c++14 is already mandatory. Ping? (In reply to comment #6) > Why do we need this change? I thought c++14 is already mandatory. Sam, please answer this question. (In reply to comment #11) > (In reply to comment #6) > > Why do we need this change? I thought c++14 is already mandatory. > > Sam, please answer this question. We have an internal client that is including StdLibExtras.h that can't easily be updated to C++14. That issue should go away in a few weeks at which time we can remove this. (In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #6) > > > Why do we need this change? I thought c++14 is already mandatory. > > > > Sam, please answer this question. > > We have an internal client that is including StdLibExtras.h that can't > easily be updated to C++14. That issue should go away in a few weeks at > which time we can remove this. Thanks for the clarification, it makes sense. (In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #11) > > > (In reply to comment #6) > > > > Why do we need this change? I thought c++14 is already mandatory. > > > > > > Sam, please answer this question. > > > > We have an internal client that is including StdLibExtras.h that can't > > easily be updated to C++14. That issue should go away in a few weeks at > > which time we can remove this. > > Thanks for the clarification, it makes sense. :). |