Bug 160813

Summary: Make variant only available when compiling for C++14 or greater
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2016-08-12 12:30:52 PDT
Make variant only available when compiling for C++14 or greater
Attachments
Patch (2.45 KB, patch)
2016-08-12 12:31 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2016-08-12 12:39 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2016-08-12 12:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (2.48 KB, patch)
2016-08-12 14:55 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-08-12 12:31:10 PDT
Created attachment 285931 [details] Patch
Sam Weinig
Comment 2 2016-08-12 12:39:15 PDT
Created attachment 285932 [details] Patch
Saam Barati
Comment 3 2016-08-12 12:42:02 PDT
Comment on attachment 285932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285932&action=review > Source/WTF/wtf/StdLibExtras.h:406 > +#if !COMPILER(CLANG) || WTF_CPP_STD_VER < 14 Don't you want >= here?
Sam Weinig
Comment 4 2016-08-12 12:44:15 PDT
Created attachment 285933 [details] Patch
Sam Weinig
Comment 5 2016-08-12 12:44:22 PDT
(In reply to comment #3) > Comment on attachment 285932 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285932&action=review > > > Source/WTF/wtf/StdLibExtras.h:406 > > +#if !COMPILER(CLANG) || WTF_CPP_STD_VER < 14 > > Don't you want >= here? Ugh, yes.
Csaba Osztrogonác
Comment 6 2016-08-12 13:56:16 PDT
Why do we need this change? I thought c++14 is already mandatory.
Sam Weinig
Comment 7 2016-08-12 14:55:15 PDT
Created attachment 285958 [details] Patch
WebKit Commit Bot
Comment 8 2016-08-12 16:36:48 PDT
Comment on attachment 285958 [details] Patch Clearing flags on attachment: 285958 Committed r204433: <http://trac.webkit.org/changeset/204433>
WebKit Commit Bot
Comment 9 2016-08-12 16:36:54 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 10 2016-08-14 23:25:11 PDT
(In reply to comment #6) > Why do we need this change? I thought c++14 is already mandatory. Ping?
Csaba Osztrogonác
Comment 11 2016-08-15 10:19:39 PDT
(In reply to comment #6) > Why do we need this change? I thought c++14 is already mandatory. Sam, please answer this question.
Sam Weinig
Comment 12 2016-08-15 10:36:40 PDT
(In reply to comment #11) > (In reply to comment #6) > > Why do we need this change? I thought c++14 is already mandatory. > > Sam, please answer this question. We have an internal client that is including StdLibExtras.h that can't easily be updated to C++14. That issue should go away in a few weeks at which time we can remove this.
Csaba Osztrogonác
Comment 13 2016-08-15 11:04:21 PDT
(In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #6) > > > Why do we need this change? I thought c++14 is already mandatory. > > > > Sam, please answer this question. > > We have an internal client that is including StdLibExtras.h that can't > easily be updated to C++14. That issue should go away in a few weeks at > which time we can remove this. Thanks for the clarification, it makes sense.
Sam Weinig
Comment 14 2016-08-15 11:38:19 PDT
(In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #11) > > > (In reply to comment #6) > > > > Why do we need this change? I thought c++14 is already mandatory. > > > > > > Sam, please answer this question. > > > > We have an internal client that is including StdLibExtras.h that can't > > easily be updated to C++14. That issue should go away in a few weeks at > > which time we can remove this. > > Thanks for the clarification, it makes sense. :).
Note You need to log in before you can comment on or make changes to this bug.