|Summary:||False crashes in fast/text/emoji-gender-* tests|
|Product:||WebKit||Reporter:||Jonathan Bedard <jbedard>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Major||CC:||commit-queue, glenn, lforschler, simon.fraser|
|Version:||WebKit Nightly Build|
Description Jonathan Bedard 2016-08-11 13:13:56 PDT
Comment 1 Jonathan Bedard 2016-08-11 13:22:59 PDT
Created attachment 285847 [details] Patch
Comment 2 Alexey Proskuryakov 2016-08-11 13:32:40 PDT
Comment on attachment 285847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285847&action=review Good catch! > Tools/Scripts/webkitpy/port/driver.py:447 > + self._server_process.write('#SAMPLE FINISHED\n', True) # Must be able to ignore a broken pipe here. This comment does not explain why we need to ignore a failure to write. How can it be improved to explain it?
Comment 3 Jonathan Bedard 2016-08-11 13:49:32 PDT
Created attachment 285852 [details] Patch
Comment 4 Alexey Proskuryakov 2016-08-11 14:06:19 PDT
Comment on attachment 285852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285852&action=review > Tools/Scripts/webkitpy/port/driver.py:447 > + self._server_process.write('#SAMPLE FINISHED\n', True) # Must be able to ignore a broken pipe here, target process may already be closed. A slightly shorter way to say the same is "Ignoring write errors, as target process may already be terminated."
Comment 5 WebKit Commit Bot 2016-08-16 11:05:13 PDT
Comment on attachment 285852 [details] Patch Clearing flags on attachment: 285852 Committed r204514: <http://trac.webkit.org/changeset/204514>
Comment 6 WebKit Commit Bot 2016-08-16 11:05:18 PDT
All reviewed patches have been landed. Closing bug.
Comment 7 Simon Fraser (smfr) 2016-08-16 11:13:58 PDT
I feel like this could have had a better changelog entry. I can't easily tell what the bug was and how you fixed it.