| Summary: | The jsc shell's Element host constructor should throw if it fails to construct an object. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | ASSIGNED --- | ||||||||
| Severity: | Normal | CC: | commit-queue, keith_miller, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 285840 [details]
proposed patch.
Attachment 285840 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 285841 [details]
Fixed tabs.
Thanks for the review. Landed in r204388: <http://trac.webkit.org/r204388>. |
The Element object is a test object provided in the jsc shell for testing use only. JavaScriptCore expects host constructors to either throw an error or return a constructed object. Element has a host constructor that did not obey this contract. As a result, the following statement will fail a RELEASE_ASSERT: new (Element.bind()) We should fix this.