Bug 160766

Summary:

Move dataset attribute from Element to HTMLElement / SVGElement

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, darin, dbates, rniwa, sam, webkit

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2016-08-11 08:59:16 PDT

Move dataset attribute from Element to HTMLElement / SVGElement as per the specifications:
- https://html.spec.whatwg.org/multipage/dom.html#htmlelement
- https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement

Firefox and Chrome seem to have dataset on HTMLElement but not on SVGElement.

Comment 1 Chris Dumez 2016-08-11 09:23:17 PDT

See also discussion at https://github.com/whatwg/dom/issues/280

Comment 2 Chris Dumez 2016-08-11 09:35:23 PDT

Created attachment 285830 [details]
Patch

Comment 3 WebKit Commit Bot 2016-08-11 10:50:27 PDT

Comment on attachment 285830 [details]
Patch

Clearing flags on attachment: 285830

Committed r204377: <http://trac.webkit.org/changeset/204377>

Comment 4 WebKit Commit Bot 2016-08-11 10:50:44 PDT

All reviewed patches have been landed.  Closing bug.