Bug 160689

Summary: Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Layout and RenderingAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, graouts, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Antoine Quint 2016-08-09 06:23:52 PDT
The test at canvas/philip/tests/2d.gradient.interpolate.colouralpha.html fails on macOS Sierra.
Comment 1 Antoine Quint 2016-08-09 06:24:05 PDT
<rdar://problem/24025664>
Comment 2 Antoine Quint 2016-08-09 06:31:00 PDT
Created attachment 285636 [details]
Patch
Comment 3 Alexey Proskuryakov 2016-08-09 09:34:43 PDT
Comment on attachment 285636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285636&action=review

> LayoutTests/ChangeLog:3
> +        Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra

There is another instance of this test in LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html.

Does that one also need the same fix? If it does, we presumably need to upstream the fix.
Comment 4 Antoine Quint 2016-08-10 14:43:24 PDT
Created attachment 285763 [details]
Patch
Comment 5 Dean Jackson 2016-08-11 02:51:20 PDT
Comment on attachment 285763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285763&action=review

> LayoutTests/ChangeLog:12
> +        When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
> +        However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
> +        which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
> +        interpolation âby handâ at steps of 25.5%, 50.5% and 75.5%.

Can you describe what actually changed here then? And if this is only Sierra, won't this change cause failures on El Cap and Yosemite?

> LayoutTests/ChangeLog:14
> +        * canvas/philip/tests/2d.gradient.interpolate.colouralpha.html:

I wonder if we can remove all these tests if they are duplicated in imported/w3c/canvas
Comment 6 Antoine Quint 2016-08-11 02:53:27 PDT
Created attachment 285824 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-08-11 03:23:35 PDT
Comment on attachment 285824 [details]
Patch for landing

Clearing flags on attachment: 285824

Committed r204371: <http://trac.webkit.org/changeset/204371>
Comment 8 WebKit Commit Bot 2016-08-11 03:23:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Antoine Quint 2016-08-12 01:59:48 PDT
Upstreaming the fix to the W3C web-platform-tests repository, see https://github.com/w3c/web-platform-tests/pull/3458.