Bug 160624

Summary: Align Range.insertNode() input validation with the specification
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#dom-range-insertnode
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-08-05 19:19:56 PDT
Align Range.insertNode() input validation with the specification: - https://dom.spec.whatwg.org/#dom-range-insertnode - https://dom.spec.whatwg.org/#concept-range-insert (step 1) In particular, if range’s start node is a ProcessingInstruction or Comment node, is a Text node whose parent is null, or is node, then we should throw a HierarchyRequestError. Chrome behaves according to the specification.
Attachments
Patch (24.15 KB, patch)
2016-08-05 19:21 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-05 19:21:53 PDT
Created attachment 285474 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-05 20:18:33 PDT
Comment on attachment 285474 [details] Patch Clearing flags on attachment: 285474 Committed r204217: <http://trac.webkit.org/changeset/204217>
WebKit Commit Bot
Comment 3 2016-08-05 20:18:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.